Move django-heroku to prod dependencies, update requirements #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few issues with the poetry dependency groups that I've spotted a little while ago; the main issue is that the dependency groups are not doing anything. Currently, all dependencies will be installed regardless of what group they are in, since none of the groups are marked as optional. This means that when installing with
poetry install
(even withpoetry install --with=dev
), all the dependencies across dev and prod are installed.This PR marks the prod dependency group as optional, which fixes the above issue. The export command should still say the same (the
--with=prod
now actually does something). Further, since the dev dependency group remains not optional, just a simplepoetry install --no-root
would install all the main and dev dependencies; the prior--with=dev
does nothing.There is also currently a requirement for
psycopg
for local installation, which is technically not needed anymore with Docker; further, this is a child dependency ofdjango-heroku
, which is also not needed for non-prod environments. People will need to install all the poetry dependencies locally to runpre-commit
, which means that they'll be required to install PostgreSQL forpre-commit
, which is a large pain that we wanted to avoid through Docker.This PR moves the
django-heroku
dependency into the prod dependencies list, which removes it from the dependencies when installing throughpoetry install
.In the process, some of the dependencies have been updated, and pre-commit hooks have been updated as well.