Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move django-heroku to prod dependencies, update requirements #457

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

smartspot2
Copy link
Member

@smartspot2 smartspot2 commented Oct 31, 2023

There are a few issues with the poetry dependency groups that I've spotted a little while ago; the main issue is that the dependency groups are not doing anything. Currently, all dependencies will be installed regardless of what group they are in, since none of the groups are marked as optional. This means that when installing with poetry install (even with poetry install --with=dev), all the dependencies across dev and prod are installed.

This PR marks the prod dependency group as optional, which fixes the above issue. The export command should still say the same (the --with=prod now actually does something). Further, since the dev dependency group remains not optional, just a simple poetry install --no-root would install all the main and dev dependencies; the prior --with=dev does nothing.

There is also currently a requirement for psycopg for local installation, which is technically not needed anymore with Docker; further, this is a child dependency of django-heroku, which is also not needed for non-prod environments. People will need to install all the poetry dependencies locally to run pre-commit, which means that they'll be required to install PostgreSQL for pre-commit, which is a large pain that we wanted to avoid through Docker.

This PR moves the django-heroku dependency into the prod dependencies list, which removes it from the dependencies when installing through poetry install.

In the process, some of the dependencies have been updated, and pre-commit hooks have been updated as well.

@smartspot2 smartspot2 self-assigned this Oct 31, 2023
@cypress
Copy link

cypress bot commented Oct 31, 2023

Passing run #285 ↗︎

0 78 0 0 Flakiness 0

Details:

Update poetry dev/prod dependencies, update setup scripts and Github CI
Project: csm_web Commit: 84bf3ec772
Status: Passed Duration: 01:56 💡
Started: Dec 19, 2023 7:42 AM Ended: Dec 19, 2023 7:44 AM

Review all test suite changes for PR #457 ↗︎

@smartspot2 smartspot2 marked this pull request as ready for review November 23, 2023 07:31
@smartspot2 smartspot2 added bug Something isn't working dependencies Pull requests that update a dependency file labels Dec 19, 2023
Copy link
Contributor

@ericyche ericyche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ak

@smartspot2 smartspot2 merged commit 84bf3ec into master Dec 19, 2023
16 checks passed
@smartspot2 smartspot2 deleted the deps/psycopg branch December 19, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants