Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional validation to various forms #465

Merged
merged 9 commits into from
Feb 29, 2024

Conversation

smartspot2
Copy link
Member

Resolves #441

The section creation form and the override creation form have been causing several errors in the backend, since there is no input validation in the frontend. These forms have now been updated to provide input validation, displayed to the user upon clicking the save/submit button.

@smartspot2 smartspot2 self-assigned this Feb 16, 2024
@smartspot2 smartspot2 added the bug Something isn't working label Feb 16, 2024
Copy link

cypress bot commented Feb 16, 2024

Passing run #316 ↗︎

0 78 0 0 Flakiness 0

Details:

Add additional validation to various forms (#465)
Project: csm_web Commit: c747328ef3
Status: Passed Duration: 02:30 💡
Started: Feb 29, 2024 6:15 AM Ended: Feb 29, 2024 6:17 AM

Review all test suite changes for PR #465 ↗︎

edwardneo
edwardneo previously approved these changes Feb 22, 2024
Copy link
Contributor

@edwardneo edwardneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jacovkim
jacovkim previously approved these changes Feb 22, 2024
Copy link

@jacovkim jacovkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@smartspot2 smartspot2 dismissed stale reviews from jacovkim and edwardneo via 091f528 February 22, 2024 05:23
jacovkim
jacovkim previously approved these changes Feb 22, 2024
Copy link

@jacovkim jacovkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

jacovkim
jacovkim previously approved these changes Feb 29, 2024
Copy link

@jacovkim jacovkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

edwardneo
edwardneo previously approved these changes Feb 29, 2024
Copy link
Contributor

@edwardneo edwardneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@jacovkim jacovkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a section with space in Location field fails. Setting capacity to -1 also fails. Both when creating a section or editing an existing section

@jacovkim jacovkim self-requested a review February 29, 2024 05:38
Copy link

@jacovkim jacovkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOOKS GOOD TO ME!

@edwardneo edwardneo self-requested a review February 29, 2024 06:12
Copy link
Contributor

@edwardneo edwardneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALSO LOOKS GOOD TO ME!

@smartspot2 smartspot2 merged commit c747328 into master Feb 29, 2024
16 checks passed
@smartspot2 smartspot2 deleted the fix/additional-validation branch February 29, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Validation to Section Creation window
3 participants