Restyle matcher UI #470
Merged
Restyle matcher UI #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #324 ↗︎
Details:
Review all test suite changes for PR #470 ↗︎ |
|||||||||||||||
edwardneo
requested changes
Mar 7, 2024
There was a problem hiding this comment.
Looks generally good -- why is there a save button and a submit button for creating the matcher slots, and you can hit submit without saving? It seems a bit weird to me, and I think coordinators will accidentally forget to save a slot they wanted to save but submit it anyways.
smartspot2
force-pushed
the
fix/matcher-ui
branch
from
c4b39b3
to
4541152
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes various miscellaneous improvements to the matcher UI.
Coordinators have created slots without knowing that many slots are actually linked; a confirmation modal has been added because of this, listing out all of the slots along with a count of the number of slots to submit.
Another confirmation modal was added to the button opening the preference form for mentors, making it clear that slots cannot be edited afterward. This can probably be reverted or changed if in the future we decide to rework the slot creation system to allow for slot edits.
The create stage button UI/UX was also modified; to avoid any confusion with save/submit/continue buttons, the flows were reworked to have only one green (primary) button visible at any given point in time. Clicking this button would proceed with the flow, whereas secondary buttons either cancel the flow or go to a different flow (ex. editing events).
Further, there were many matcher button and input styles that are not consistent with the rest of the site; these classes have also been migrated over.
Closes #437.