Improvements to createtestdata script
#473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartspot2
force-pushed
the
fix/createtestdata-improvements
branch
from
ace0605
to
c32616c
Compare
Passing run #336 ↗︎
Details:
Review all test suite changes for PR #473 ↗︎ |
|||||||||||||||
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
createtestdatascript creates models in a fixed deterministic order, and almost always the mentor and section ids match up. This can cause some confusions during development, since it's hard to tell which ids correspond to mentors and which correspond to sections. This PR randomly shuffles all of the models prior to creation, to randomize the ids.Further, all of the sections have very few mentors, and all courses have very few sections. This makes it quite hard to test query and frontend efficiency for larger courses and larger sections. This PR adds a few additional courses, with various combinations of many sections vs. many students per section.