Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose to allow migrations to be created in Docker #476

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

smartspot2
Copy link
Member

Currently, running docker compose exec django makemigrations will error, since the Django file system in Docker is read-only. This PR modifies the bind mounts to allow writes to the migrations folder. (The migrations folder in the frontend app is not included here, since we only make database changes within the scheduler app.)

@smartspot2 smartspot2 added the bug Something isn't working label Jul 13, 2024
@smartspot2 smartspot2 self-assigned this Jul 13, 2024
Copy link

cypress bot commented Jul 13, 2024

Passing run #342 ↗︎

0 78 0 0 Flakiness 0

Details:

Update docker-compose to allow migrations to be created in Docker (#476)
Project: csm_web Commit: 8f191fccd6
Status: Passed Duration: 01:57 💡
Started: Jul 23, 2024 2:54 AM Ended: Jul 23, 2024 2:56 AM

Review all test suite changes for PR #476 ↗︎

Copy link
Contributor

@edwardneo edwardneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smartspot2 smartspot2 merged commit 8f191fc into master Jul 23, 2024
16 checks passed
@smartspot2 smartspot2 deleted the fix/docker-django-migrations branch July 23, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants