Replace django get_random_secret_key with secrets.token_hex #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csm_web
|
||||||||||||||||||||||||||||
| Project |
csm_web
|
| Branch Review |
fix/setup-secret-key
|
| Run status |
|
| Run duration | 02m 26s |
| Commit |
|
| Committer | Alec Li |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
78
|
| View all changes introduced in this branch ↗︎ | |
smartspot2
force-pushed
the
fix/setup-secret-key
branch
from
d8f3099
to
f1e2119
Compare
|
Merged the PR without review since it's just a development setup change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With prior dependency changes, we no longer install
psycopgonto users' computers, but theget_random_secret_keyfunction used insetup.shrequires Django to be fully set up prior to calling the function. As such, the function errors due to the missing dependency.Since the secret key generated here is only going to be used for development, we can simply replace it with a more straightforward
secrets.token_hex(32), despite its much lesser security.