Add slot descriptions, matcher randomness #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartspot2
added
enhancement
csm_web
|
||||||||||||||||||||||||||||
| Project |
csm_web
|
| Branch Review |
feat/matcher-improvements
|
| Run status |
|
| Run duration | 02m 33s |
| Commit |
|
| Committer | Alec Li |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
78
|
| View all changes introduced in this branch ↗︎ | |
smartspot2
force-pushed
the
feat/matcher-improvements
branch
from
5afad51
to
9dd5d6a
Compare
smartspot2
force-pushed
the
feat/matcher-improvements
branch
from
f2a0632
to
f9629c9
Compare
smartspot2
force-pushed
the
feat/matcher-improvements
branch
from
f9629c9
to
65b3442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #466.
Matcher slots currently have no special metadata that coordinators can use to indicate special sections with---this information needs to be communicated to mentors separately. Adding a description to slots allows for this metadata to be embedded within the matcher, so mentors can see whether sections have any special tags (ex. NPE, affinity section, etc.) prior to filling availability.
Secondly, this PR also adds some randomness to the matcher algorithm, randomly shuffling the lists of mentors/slots/preferences so that tiebreaks happen approximately uniformly.