Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exclude config from CSSComb #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use exclude config from CSSComb #41

wants to merge 1 commit into from

Conversation

wardpeet
Copy link

CSSComb doesn't uses the exclude from config.
I added a check that grunt only processes when necessary, else it copies the files.

"exclude": [
        ".git/**",
        "node_modules/**",
        "bower_components/**",
        "**/exclude2.css"
    ],

@tonyganch
Copy link
Member

Hello, @wardpeet. I'm very sorry to keep you waiting for review.
Are you still interested in merging this pr?

@wardpeet
Copy link
Author

Yes please :) If i need to change anything just let me know.

@tonyganch
Copy link
Member

Can you please rebase your branch onto master? There are now some conflicts preventing me from easy merging.

@wardpeet
Copy link
Author

Will rebase today :)

@wardpeet
Copy link
Author

Sorry for the delay, I rebased to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wardpeet @tonyganch