Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor: Tomato to sofia #469

Draft
wants to merge 3 commits into
base: staging
Choose a base branch
from
Draft

Conversation

lodewiges
Copy link
Contributor

It is written in a way so that the connecting between Amber en sofia still works. This can be removed at a later date to clean up the code. this is also needed because I am unaware of the implementation on luxstreep.

still need to write the migration for the users

needs to be merged as the same time as the amber-ui version

@lodewiges lodewiges marked this pull request as draft November 21, 2024 23:46
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.94%. Comparing base (fbf1070) to head (50d0c83).
Report is 13 commits behind head on staging.

Files with missing lines Patch % Lines
app/policies/user_policy.rb 25.00% 3 Missing ⚠️
app/resources/v1/user_resource.rb 25.00% 3 Missing ⚠️
app/models/user.rb 80.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fbf1070) and HEAD (50d0c83). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (fbf1070) HEAD (50d0c83)
2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           staging     #469       +/-   ##
============================================
- Coverage    99.92%   67.94%   -31.99%     
============================================
  Files          207      203        -4     
  Lines         2733     2714       -19     
============================================
- Hits          2731     1844      -887     
- Misses           2      870      +868     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant