album tag counter #887
Merged
album tag counter #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #887 +/- ##
===========================================
+ Coverage 13.44% 13.57% +0.13%
===========================================
Files 439 439
Lines 3110 3115 +5
===========================================
+ Hits 418 423 +5
Misses 2692 2692 ☔ View full report in Codecov by Sentry. |
lodewiges
reviewed
Oct 18, 2024
| @@ -5,11 +5,18 @@ | |||
| src='{{album.albumMediumUrl}}' | |||
| class='card-img-rounded' | |||
| /> | |||
|
|
|||
There was a problem hiding this comment.
i think this blank space shouldn't be here
lodewiges
approved these changes
Oct 21, 2024
|
@ToMaarton be careful with posting pictures containing personal information / photos of people. For example the gala photo in your last screenshot is not a public picture. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Issue#870) A small tag is added to the photo album cover cards, the number of photos that have been tagged out of the total amount of photos.
The tag does not show up for albums in which none of the photos have been tagged or that do not contain any photos.
The goal is to provide an easy way to check if the photos in the album have been tagged.
(Issue#863) The similar issue is fixed by also displaying the tag count of each photo in the same box as the comment count.