Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing a button for Presence in the 2de kamer #891

Open
wants to merge 8 commits into
base: staging
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed a mistake in the name of a file
  • Loading branch information
lodewiges committed Oct 27, 2024
commit 1e529e9e6326e8da74dc2f199d93cc31ac005ad5
File renamed without changes.
2 changes: 1 addition & 1 deletion app/components/tools/study-room-presence.hbs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also write this template in octane style. Some quick rules (without regard for whether you followed these or not):

  • use angle bracket syntax for inserting components
  • refer to controller properties/functions with this. i.e. this.property or this.someFunction
  • refer to arguments passed to this component using @. So, if the parent component has passed an argument called someArgument, then we can refer to it in this template with @someArgument.
  • do not use the action helper anymore. see Refactor: {{action}} helper usage #635 and Refactor: {{action}} helper usage, the sequel #896 for examples of what to write instead.

please thoroughly familiarize yourself with #429 and the tutorials/guides/resources mentioned there.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class='room-presence-dropdown page-action'>
<BsButton @type='primary'>
<FaIcon @icon='book-open' />
<FaIcon @icon='book' />
<span class='d-none d-md-inline'>2de kamer</span>
<span class='status-dot label-{{overallStatus}}'></span>

Loading