Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IBAN option from group export #939

Merged
merged 2 commits into from
Mar 9, 2025
Merged

Conversation

lodewiges
Copy link
Contributor

@lodewiges lodewiges commented Feb 17, 2025

Fixes #940

I removed the ability to download all IBAN because it is not stored in the user table but in the mandates table. besides that it is really sensitive data.

If we need this functionality we need to a export button to the mandates tab or fix it some other way

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.37%. Comparing base (ea79dbc) to head (904a21c).
Report is 8 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging     #939   +/-   ##
========================================
  Coverage    13.37%   13.37%           
========================================
  Files          450      450           
  Lines         3117     3117           
========================================
  Hits           417      417           
  Misses        2700     2700           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DrumsnChocolate DrumsnChocolate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure the avatar url is never used in the export?

@lodewiges
Copy link
Contributor Author

lodewiges commented Mar 9, 2025

Are we sure the avatar url is never used in the export?

i don't see the value of exporting. besides that it is for the manual export function

@lodewiges lodewiges added this pull request to the merge queue Mar 9, 2025
Merged via the queue into staging with commit 79e42f5 Mar 9, 2025
5 checks passed
@lodewiges lodewiges deleted the fix/user-export-IBAN branch March 9, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User export IBAN fields not working
2 participants