Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): add code coverage reporting #891

Merged
merged 10 commits into from
Nov 27, 2024
Merged

feat(tests): add code coverage reporting #891

merged 10 commits into from
Nov 27, 2024

Conversation

guidojw
Copy link
Member

@guidojw guidojw commented Oct 13, 2023

Summary

Adds code coverage reporting with Codecov.

requires #945

@guidojw guidojw marked this pull request as draft October 13, 2023 19:52
@guidojw guidojw marked this pull request as ready for review October 13, 2023 20:47
@guidojw guidojw enabled auto-merge October 13, 2023 20:47
@codecov
Copy link

codecov bot commented Oct 13, 2023

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@lodewiges
Copy link
Contributor

this first needs a fix similair to amber-api
csvalpha/amber-api#441
csvalpha/amber-api#444

@guidojw
Copy link
Member Author

guidojw commented Nov 22, 2024

@lodewiges fixed

@lodewiges
Copy link
Contributor

lodewiges commented Nov 22, 2024

This doesnt fixes it if i am correct or maybe it does?
I already made a seprate PR for it: #945
so either way it should be alright

@guidojw
Copy link
Member Author

guidojw commented Nov 22, 2024

It does fix it, I missed some changes copying it from the other similar prs before but it should be good now

@guidojw guidojw added this pull request to the merge queue Nov 27, 2024
Merged via the queue into staging with commit 0daa494 Nov 27, 2024
5 checks passed
@guidojw guidojw deleted the feat/codecov branch November 27, 2024 14:49
DrumsnChocolate added a commit that referenced this pull request Nov 29, 2024
* chore(deps): update dependency paranoia to v3 (#931)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Edited the env file (#944)

* edited the env file

* changed company name to UTF-8

* chore(deps): update dependency puma to '~> 6.4.0' [security] (#935)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/delete-package-versions action to v5 (#906)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency rails to v7.0.8.1 [security] (#918)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update docker/build-push-action action to v6 (#928)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update docker/login-action action to v3 (#886)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(tests): add code coverage reporting (#891)

* feat(tests): add code coverage reporting

* fix: correct coverage path

* refactor: use simplecov-lcov

* fix: indentation in Gemfile.lock

* fix: remove test filters

* feat(README): add badge

* refactor: try tokenless report uploading

* chore: update codecov-action

* chore: update codecov-action

* fix(cd): pass CODECOV_TOKEN To ci

* Revert "chore(deps): update docker/login-action action to v3 (#886)" (#951)

This reverts commit d546681. due to CI failure

* chore(deps): update codecov/codecov-action action to v5 (#950)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency puma to v6.4.3 [security] (#948)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/upload-artifact action to v4 (#949)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Refractor/tomato to sofia (#947)

* Intial commit

* updated apliction.rb

* Fixed mistake in credentials

* Made it so the file is backwards compatiable

* Fixed a typo

* Update amber_oauth2.rb

remove tomato paramater

* Remove development title lux ad mosam (#946)

* intial commit

* Fix typo

* update tomato to sofia

* updated with suggestion

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: lodewiges <[email protected]>
Co-authored-by: Guido de Jong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants