Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a small test to avoid random fails #1276

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix a small test to avoid random fails #1276

merged 1 commit into from
Jul 19, 2024

Conversation

deborahDOR
Copy link
Collaborator

@deborahDOR deborahDOR commented Jul 11, 2024 •
edited by chaimain
Loading

Fixes #1275

@deborahDOR
Fixes #1275
655d729 
Fix a small test in ltschain/tools/tests/test_tools.py to avoid random fails
@deborahDOR deborahDOR linked an issue Jul 11, 2024 that may be closed by this pull request
Randomly (?) failing test #1275
Closed
@deborahDOR deborahDOR assigned deborahDOR and chaimain and unassigned deborahDOR Jul 11, 2024
@chaimain chaimain changed the title Fixes #1275 Fix a small test to avoid random fails Jul 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.35%. Comparing base (ef91c64) to head (655d729).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1276   +/-   ##
=======================================
  Coverage   73.35%   73.35%           
=======================================
  Files         134      134           
  Lines       14117    14117           
=======================================
  Hits        10356    10356           
  Misses       3761     3761

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deborahDOR deborahDOR requested a review from chaimain July 11, 2024 17:07
@deborahDOR deborahDOR assigned deborahDOR and unassigned chaimain Jul 11, 2024
@chaimain chaimain requested a review from gabemery July 12, 2024 06:29
@deborahDOR deborahDOR removed their assignment Jul 12, 2024
@moralejo moralejo merged commit d1498cc into main Jul 19, 2024
9 checks passed
@morcuended morcuended deleted the 1275-randomly-failing-test branch July 30, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morcuended morcuended morcuended approved these changes

@gabemery gabemery gabemery approved these changes

@chaimain chaimain chaimain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Randomly (?) failing test
5 participants
@deborahDOR @morcuended @gabemery @chaimain @moralejo