use TelescopeFrame in doc notebooks

cta-observatory · Jan 9, 2023 · a5ce34b · a5ce34b
1 parent 27d3457
commit a5ce34b
Show file tree

Hide file tree

Showing 8 changed files with 2,445 additions and 384 deletions.
diff --git a/docs/examples/camera_display.ipynb b/docs/examples/camera_display.ipynb
diff --git a/docs/examples/convert_images_to_2d.ipynb b/docs/examples/convert_images_to_2d.ipynb
diff --git a/docs/examples/dilate_image.ipynb b/docs/examples/dilate_image.ipynb
diff --git a/docs/tutorials/calibrated_data_exploration.ipynb b/docs/tutorials/calibrated_data_exploration.ipynb
diff --git a/docs/tutorials/ctapipe_handson.ipynb b/docs/tutorials/ctapipe_handson.ipynb
diff --git a/docs/tutorials/ctapipe_overview.ipynb b/docs/tutorials/ctapipe_overview.ipynb
diff --git a/examples/plot_camera_frames.py b/examples/plot_camera_frames.py
@@ -5,7 +5,7 @@
 import astropy.units as u
 import matplotlib.pyplot as plt
 
-from ctapipe.coordinates import EngineeringCameraFrame
+from ctapipe.coordinates import EngineeringCameraFrame, TelescopeFrame
 from ctapipe.image.toymodel import Gaussian
 from ctapipe.instrument import SubarrayDescription
 from ctapipe.visualization import CameraDisplay
@@ -14,16 +14,17 @@
 def main():
     fig, axs = plt.subplots(1, 2, constrained_layout=True, figsize=(6, 3))
 
-    model = Gaussian(0 * u.m, 0.1 * u.m, 0.3 * u.m, 0.05 * u.m, 25 * u.deg)
+    model = Gaussian(0 * u.deg, 0.1 * u.deg, 0.6 * u.deg, 0.10 * u.deg, 25 * u.deg)
 
     subarray = SubarrayDescription.read("dataset://gamma_prod5.simtel.zst")
-    cam = subarray.tel[5].camera.geometry
+    geom_cam = subarray.tel[5].camera.geometry
+    geom_tel = subarray.tel[5].camera.geometry.transform_to(TelescopeFrame())
 
-    image, *_ = model.generate_image(cam, 2500)
+    image, *_ = model.generate_image(geom_tel, 2500)
 
-    CameraDisplay(cam, ax=axs[0], image=image)
+    CameraDisplay(geom_tel.transform_to(geom_cam.frame), ax=axs[0], image=image)
     CameraDisplay(
-        cam.transform_to(EngineeringCameraFrame()),
+        geom_tel.transform_to(geom_cam.frame).transform_to(EngineeringCameraFrame()),
         ax=axs[1],
         image=image,
     )

diff --git a/examples/plot_hillas_parameters.py b/examples/plot_hillas_parameters.py
@@ -6,6 +6,7 @@
 import astropy.units as u
 import matplotlib.pylab as plt
 
+from ctapipe.coordinates import TelescopeFrame
 from ctapipe.image import hillas_parameters, tailcuts_clean, toymodel
 from ctapipe.instrument import SubarrayDescription
 from ctapipe.visualization import CameraDisplay
@@ -14,13 +15,13 @@
 
     # Load the camera
     subarray = SubarrayDescription.read("dataset://gamma_prod5.simtel.zst")
-    geom = subarray.tel[1].camera.geometry
+    geom = subarray.tel[1].camera.geometry.transform_to(TelescopeFrame())
     disp = CameraDisplay(geom)
     disp.add_colorbar()
 
     # Create a fake camera image to display:
     model = toymodel.Gaussian(
-        x=0.2 * u.m, y=0.0 * u.m, width=0.05 * u.m, length=0.15 * u.m, psi="35d"
+        x=0.2 * u.deg, y=0.0 * u.deg, width=0.10 * u.deg, length=0.30 * u.deg, psi="35d"
     )
 
     image, sig, bg = model.generate_image(geom, intensity=1500, nsb_level_pe=2)