Merge pull request #2547 from cta-observatory/remove_xfail

Fix CI
cta-observatory · Apr 25, 2024 · d3121f7 · d3121f7
2 parents d7e67e6 + 77b7f11
commit d3121f7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -42,7 +42,7 @@ dependencies = [
     "psutil",
     "pyyaml >=5.1",
     "requests",
-    "scikit-learn <1.4",
+    "scikit-learn !=1.4.0", # 1.4.0 breaks with astropy tables, before and after works
     "scipy ~=1.2",
     "tables ~=3.4",
     "tqdm >=4.32",

diff --git a/src/ctapipe/io/tests/test_hdf5.py b/src/ctapipe/io/tests/test_hdf5.py
@@ -865,9 +865,7 @@ def test_write_default_container(cls, tmp_path):
         except ValueError as e:
             # some containers do not have writable members,
             # only subcontainers. For now, ignore them.
-            if "cannot create an empty data type" in str(e):
-                pytest.xfail()
-            else:
+            if "cannot create an empty data type" not in str(e):
                 raise
 
 

diff --git a/src/ctapipe/reco/tests/test_ImPACT.py b/src/ctapipe/reco/tests/test_ImPACT.py
@@ -177,7 +177,7 @@ def test_fitting(self, tmp_path, example_subarray, table_profile):
 
         impact_reco.get_hillas_mean()
 
-        seed, step, limits = create_seed(0.0, 0.0, 0.0, 0.0, 0.8)
+        seed, step, limits = create_seed(0.0, 0.0, 0.0, 0.0, 0.5)
         vals, error, chi2 = impact_reco.minimise(seed, step, limits)
         assert_allclose(vals[4], 1, rtol=0.05)