Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observatory location to SubarrayDescription #1031

Closed
kosack opened this issue Mar 26, 2019 · 3 comments · Fixed by #1980
Closed

Add observatory location to SubarrayDescription #1031

kosack opened this issue Mar 26, 2019 · 3 comments · Fixed by #1980

Comments

@kosack
Copy link
Contributor

kosack commented Mar 26, 2019

the SubarrayDescription (built currently in each EventSource) should contain the location of the observatory as an astropy.coordintates.EarthLocation. This is needed e.g. for some coordinate transforms.

I suggest we add it as a field called "location", so we can do things like:

subarray = SubarrayDescription(...)
elevation = subarray.location.height
# <Quantity 2124. m>
@kosack
Copy link
Contributor Author

kosack commented Mar 26, 2019

see #1030

@maxnoe
Copy link
Member

maxnoe commented Jun 2, 2022

With this added, we should also enable transformations to/from GroundFrame to ITRS:
https://docs.astropy.org/en/stable/api/astropy.coordinates.ITRS.html

Which makes it easy to get individual earth locations for each telescope

@maxnoe
Copy link
Member

maxnoe commented Jul 12, 2022

Done in #1980

@maxnoe maxnoe closed this as completed Jul 12, 2022
@maxnoe maxnoe added this to the v0.16.0 milestone Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants