Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location of subarray reference point to SubarrayDescription #1980

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jun 30, 2022

No description provided.

kosack
kosack previously approved these changes Jun 30, 2022
Copy link
Contributor

@kosack kosack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this has been missing for a while!

It will make the alt/az → ICRS transformations nicer, and also maybe later we can add a map imagery overlay to the ArrayDisplay now that we also have the EastingNorthingFrame. I hacked a version at one point:

image

LukasNickel
LukasNickel previously approved these changes Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #1980 (f3165fb) into master (5341875) will increase coverage by 0.02%.
The diff coverage is 95.20%.

@@            Coverage Diff             @@
##           master    #1980      +/-   ##
==========================================
+ Coverage   92.18%   92.20%   +0.02%     
==========================================
  Files         193      193              
  Lines       15238    15447     +209     
==========================================
+ Hits        14047    14243     +196     
- Misses       1191     1204      +13     
Impacted Files Coverage Δ
ctapipe/instrument/subarray.py 91.66% <73.91%> (-1.93%) ⬇️
ctapipe/io/tableloader.py 96.52% <98.83%> (+1.04%) ⬆️
ctapipe/conftest.py 94.25% <100.00%> (-0.23%) ⬇️
ctapipe/instrument/tests/test_subarray.py 100.00% <100.00%> (ø)
ctapipe/io/tests/test_hdf5eventsource.py 97.34% <100.00%> (ø)
ctapipe/io/tests/test_simteleventsource.py 100.00% <100.00%> (ø)
ctapipe/io/tests/test_table_loader.py 99.42% <100.00%> (+0.36%) ⬆️
ctapipe/utils/index_finder.py 85.71% <0.00%> (-3.58%) ⬇️
ctapipe/io/astropy_helpers.py 90.98% <0.00%> (-1.64%) ⬇️
ctapipe/image/hillas.py 98.50% <0.00%> (-1.50%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e350c...f3165fb. Read the comment docs.

@maxnoe maxnoe merged commit b572d37 into master Jul 4, 2022
@maxnoe maxnoe deleted the subarray_location branch July 4, 2022 12:58
@maxnoe maxnoe linked an issue Jul 12, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add observatory location to SubarrayDescription
4 participants