Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on python 3.12 #2486

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Test on python 3.12 #2486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fc88dc
Update CI config to include python 3.12 builds, add pytest-cov and py…
maxnoe Jan 8, 2024
bf7ab13
Remove pandas pin for tests
maxnoe Feb 7, 2024
e1c7713
Only install tests extra in test CI
maxnoe Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,19 +43,23 @@ jobs:

- os: ubuntu-latest
python-version: "3.10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why phyton 3.10 only uses pip while 3.9, 3.11, and 3.12 also tries mamba?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason, we at some point in the past decided not to test on the full product matrix of [python versions] x [pip, mamba] but to only test some combinations that cover all python versions and both installation methods.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To limit the number of parallel builds that run in the CI

install-method: mamba
extra-args: ["codecov"]
install-method: pip

- os: ubuntu-latest
python-version: "3.11"
install-method: mamba

- os: ubuntu-latest
python-version: "3.11"
python-version: "3.12"
install-method: mamba
extra-args: ["codecov"]

- os: ubuntu-latest
python-version: "3.12"
install-method: pip

- os: macos-latest
python-version: "3.11"
python-version: "3.12"
install-method: mamba

- os: macos-latest
Expand Down Expand Up @@ -116,10 +120,10 @@ jobs:
PYTHON_VERSION: ${{ matrix.python-version }}
run: |
python --version | grep "Python ${PYTHON_VERSION}"
pip install pytest-cov pytest-xdist 'coverage!=6.3.0'
pip install -e .[all]
pip install -e .[tests]
pip install ./test_plugin
pip freeze
pip list

- name: ctapipe-info
if: contains(github.event.pull_request.labels.*.name, 'documentation-only') == false
Expand Down
1 change: 1 addition & 0 deletions docs/changes/2486.maintenance.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Support and test on python 3.12.
4 changes: 3 additions & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ install_requires=
[options.extras_require]
tests =
pytest >= 7.0
pandas ~=1.0
pytest-cov
pytest-xdist
pandas
tomli
pytest_astropy_header
h5py
Expand Down
Loading