-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move options from setup.cfg to pyproject.toml #2512
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2512 +/- ##
=======================================
Coverage 92.52% 92.53%
=======================================
Files 235 235
Lines 20024 20024
=======================================
+ Hits 18528 18530 +2
+ Misses 1496 1494 -2 ☔ View full report in Codecov by Sentry. |
af596a0
to
ac56396
Compare
Sorry, needed to update the |
.eggs | ||
max-line-length=90 | ||
select = C,E,F,W,B,B950 | ||
ignore = E501,W503,E203,W201,E712,E731 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these settings recreated outside the toml, or are they not relevant any more for some other reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flake8 does not support being configured via pyproject.toml (the maintainer hates it for some reason) and since we intend to move to ruff (#2416) I didn't bother adding it to a .flake8 file
Switch to using the standardized metadata and config for setuptools in pyproject.toml, gets rid of one config file.