Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change R1- and DL0-waveforms shape to (n_channels, n_pixels, n_samples) #2529

Merged
merged 42 commits into from
Apr 24, 2024
Merged

Change R1- and DL0-waveforms shape to (n_channels, n_pixels, n_samples) #2529

merged 42 commits into from
Apr 24, 2024

Commits on Apr 23, 2024

  1. Initial commit

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b1c862a View commit details
    Browse the repository at this point in the history

  2. Adapting CameraCalibrator 

     - Fixing some unit tests
    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    fd7fc3a View commit details
    Browse the repository at this point in the history

  3. Enhance Toymodel 

     - Adapt toymodel to the current needs
 - Add possibility to create 2 gain toymodel
    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    2fb7f06 View commit details
    Browse the repository at this point in the history

  4. Fix tests

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f547cfb View commit details
    Browse the repository at this point in the history

  5. Adapting shift_waveforms test 

     - now testing that it also works for n_channels
    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6268cbb View commit details
    Browse the repository at this point in the history

  6. Fix reducer

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f4a2916 View commit details
    Browse the repository at this point in the history

  7. Change GainSelector handle new waveforms shape 

     - With the current API of the GainSelector its not possible anymore
 - to distinguish between gain selected waveforms and waveforms
 - that only have one gain channel
    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d57dedd View commit details
    Browse the repository at this point in the history

  8. Adapt some comment

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d7d450c View commit details
    Browse the repository at this point in the history

  9. Minor fixes

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1411bdd View commit details
    Browse the repository at this point in the history

  10. Make CameraCalibrator work for not gain selected data

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9e7b2b5 View commit details
    Browse the repository at this point in the history

  11. Change datamodel version

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    151e9c0 View commit details
    Browse the repository at this point in the history

  12. Test shift_waveforms for both use cases 

     - 1 gain channel and 2 gain channel
    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e93b35c View commit details
    Browse the repository at this point in the history

  13. Test wrong ndim in GainSelector

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a693088 View commit details
    Browse the repository at this point in the history

  14. Add toymodel test for wrong gain channel

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7c5a4d0 View commit details
    Browse the repository at this point in the history

  15. Update test for neighbor_average_maximum

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7a3cf78 View commit details
    Browse the repository at this point in the history

  16. Fix GlobalPeakWindowSum for 2 gains

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    279e6bf View commit details
    Browse the repository at this point in the history

  17. Add Changelog

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9a65df2 View commit details
    Browse the repository at this point in the history

  18. Fix docs 

     - close remaining open file
 - fix changelog
    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7633667 View commit details
    Browse the repository at this point in the history

  19. Minor beauty changes

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    074f405 View commit details
    Browse the repository at this point in the history

  20. Delete breakpoint ...-.-

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e50eb72 View commit details
    Browse the repository at this point in the history

  21. Keep compatibility for older datamodel versions

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    89bf1dd View commit details
    Browse the repository at this point in the history

  22. Create helper function for applying integration correction

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0bad55c View commit details
    Browse the repository at this point in the history

  23. Keep dtype after correction

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a76ea8f View commit details
    Browse the repository at this point in the history

  24. Handle broken pixels with 2 gain channels 

     - Adapted extractors and calibrator to handel broken pixels for multiple gain channels
 - InvalidPixelHandel cannot handle multiple gain channels for now
    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3b82775 View commit details
    Browse the repository at this point in the history

  25. Minor Fix

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    dfff566 View commit details
    Browse the repository at this point in the history

  26. Change broken_pixels to have always shape (n_channels, n_pixels)

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    fa56126 View commit details
    Browse the repository at this point in the history

  27. Adapt InvalidPixelHandler to work with 2 gain channels

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    82a956a View commit details
    Browse the repository at this point in the history

  28. Fix reference

    @maxnoe @Hckjs
    maxnoe authored and Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    887eb6d View commit details
    Browse the repository at this point in the history

  29. Change charge and peak_time calibration broadcasting 

     - I actually cant remember why i used transpose to broadcast the calib
   coeffs to the charges and peak times. I think it was due to a usecase
   which is actually not needed.
 - I've added a test especially for 2 gain data to check that the
   calibrator also works this way
    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9ebbdd5 View commit details
    Browse the repository at this point in the history

  30. Adapting changelog

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    732c5cf View commit details
    Browse the repository at this point in the history

  31. Add test for 2 gains in InvaliPixelHandler

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a85cc58 View commit details
    Browse the repository at this point in the history

  32. Add select_gain option to SimTelEventSource

    @maxnoe @Hckjs
    maxnoe authored and Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    bd59741 View commit details
    Browse the repository at this point in the history

  33. Calibration coefficients always have shape (n_channels, n_pixels) 

    Co-Authored-By: Jonas Hackfeld <[email protected]>
    @maxnoe @Hckjs
    maxnoe and Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    25c3bce View commit details
    Browse the repository at this point in the history

  34. Test all tels in first event

    @maxnoe @Hckjs
    maxnoe authored and Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9fe0018 View commit details
    Browse the repository at this point in the history

  35. Remove unneeded differentiation between simtel and "real" data in fla… 

    …tfield
    @maxnoe @Hckjs
    maxnoe authored and Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0a2e309 View commit details
    Browse the repository at this point in the history

  36. Improve readability

    @maxnoe @Hckjs
    maxnoe authored and Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0402d1b View commit details
    Browse the repository at this point in the history

  37. Cache pixel index

    @maxnoe @Hckjs
    maxnoe authored and Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    4ad3edb View commit details
    Browse the repository at this point in the history

  38. Adressing some minor comments

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    596abb3 View commit details
    Browse the repository at this point in the history

  39. Merge calibrator test for 1 and 2 gain channels

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9697f7b View commit details
    Browse the repository at this point in the history

  40. Move _apply_correction into the ImageExtractor parent class 

     - _apply_correction is now a static method from ImageExtractors parent
   class
 - _calculate_correction is moved to the parent ImageExtractors class
   to avoid writing the docstrings multiple times. It needs to be
   overwritten by the child components
    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f932630 View commit details
    Browse the repository at this point in the history

  41. Remove unnecessary instantiation

    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    07646b7 View commit details
    Browse the repository at this point in the history

  42. Fix wrong merge in table_writer_reader.py 

     - it duplicated the changes made in main, had to remove one of them
    @Hckjs
    Hckjs committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e37bb41 View commit details
    Browse the repository at this point in the history