Skip to content

Commit

Permalink
upgrade catch2 to v3.7.0
Browse files Browse the repository at this point in the history
  • Loading branch information
scholarsmate committed Oct 21, 2024
1 parent 0e03ed7 commit 9c3b01e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ if (BUILD_TESTS)
Catch2
GIT_SHALLOW TRUE
GIT_REPOSITORY https://github.com/catchorg/Catch2.git
GIT_TAG v3.5.4
GIT_TAG v3.7.0
)
FetchContent_MakeAvailable(Catch2)
list(APPEND CMAKE_MODULE_PATH "${Catch2_SOURCE_DIR}/extras")
Expand Down
3 changes: 2 additions & 1 deletion packages/server/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,10 @@ async function executeServer(args: string[]): Promise<ChildProcess> {

const serverProcess: ChildProcess = spawn(serverScript, args, {
cwd: path.dirname(serverScript),
stdio: 'ignore',
detached: true,
shell: os.platform().startsWith('win'), // use shell on Windows because it can't execute scripts directly
stdio: ['ignore', 'ignore', 'ignore'],
windowsHide: true, // avoid showing a console window
})

serverProcess.on('error', (err: Error) => {
Expand Down

0 comments on commit 9c3b01e

Please sign in to comment.