Skip to content

Commit

Permalink
retire macos-12 from CI
Browse files Browse the repository at this point in the history
  • Loading branch information
scholarsmate committed Dec 3, 2024
1 parent 5002b2c commit d80688d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 21 deletions.
13 changes: 2 additions & 11 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,6 @@ jobs:
checkName: "TypeScript code is properly formatted"
ref: ${{ github.event.pull_request.head.sha || github.sha }}

- name: Check tests - macOS 12 ✅
uses: fountainhead/[email protected]
id: macos12-tests
with:
token: ${{ secrets.GITHUB_TOKEN }}
# This check name is defined as the github action job name (in .github/workflows/testing.yaml)
checkName: "Build middleware macos-12 🔧"
ref: ${{ github.event.pull_request.head.sha || github.sha }}

- name: Check tests - macOS 14 ✅
uses: fountainhead/[email protected]
id: macos14-tests
Expand Down Expand Up @@ -217,7 +208,7 @@ jobs:
name: ubuntu-20.04-arm64-libomega_edit.so
path: _install/libomega_edit_linux_aarch64.so

- name: Download macos-12 library file 🔻
- name: Download macos-14 library file 🔻
uses: dawidd6/action-download-artifact@v7
with:
workflow: tests.yml
Expand All @@ -232,7 +223,7 @@ jobs:
workflow: tests.yml
branch: main
workflow_conclusion: success
name: macos-12-x64-libomega_edit.dylib
name: macos-14-x64-libomega_edit.dylib
path: _install/libomega_edit_macos_x86_64.dylib

- name: Download windows library file 🔻
Expand Down
12 changes: 2 additions & 10 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,7 @@ jobs:
strategy:
matrix:
# NOTE: build on older OS versions to support older OS versions
# macos-14 is m1 mac
# macos-13 not used as it doesn't by default have sbt installed.
# if macos-12 is updated to 13 SBT needs to be installed before
# trying to run it for every workflow using this os.
os: [ windows-2019, macos-12, ubuntu-20.04, macos-14 ]
os: [ windows-2019, ubuntu-20.04, macos-14 ]
fail-fast: false # don't immediately fail all other jobs if a single job fails
name: Native build and test on ${{ matrix.os }} 🦙
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -62,11 +58,7 @@ jobs:
strategy:
matrix:
# NOTE: build on older OS versions to support older OS versions
# macos-14 is m1 mac
# macos-13 not used as it doesn't by default have sbt installed.
# if macos-12 is updated to 13 SBT needs to be installed before
# trying to run it for every workflow using this os.
os: [ windows-2019, macos-12, ubuntu-20.04, macos-14 ]
os: [ windows-2019, ubuntu-20.04, macos-14 ]
fail-fast: false
runs-on: ${{ matrix.os }}
name: Build middleware ${{ matrix.os }} 🔧
Expand Down

0 comments on commit d80688d

Please sign in to comment.