Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

83 the final attack on dog page #88

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

orvielalz
Copy link
Member

added yup validation but ran into errors

@orvielalz orvielalz requested a review from Madhu2244 May 5, 2023 20:48
const isDate = str => {
try {
const ISOString = str.toISOString();
console.log('hellooooo');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

try {
const ISOString = str.toISOString();
console.log('hellooooo');
console.log(str(ISOString));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

const ISOString = str.toISOString();
console.log('hellooooo');
console.log(str(ISOString));
//!/\d{4}-\d{2}-\d{2}/.test(ISOString)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//!' in comment.

Suggested change
//!/\d{4}-\d{2}-\d{2}/.test(ISOString)
//! /\d{4}-\d{2}-\d{2}/.test(ISOString)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants