155 edit event modal + button #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctc-devops
reviewed
Apr 13, 2024
| // setEventEndTime(endTime); | ||
| setEventData(event); | ||
| manipulateDate(); | ||
| }, [isOpen]); |
There was a problem hiding this comment.
React Hook useEffect has missing dependencies: 'event' and 'manipulateDate'. Either include them or remove the dependency array. If 'setEventData' needs the current value of 'event', you can also switch to useReducer instead of useState and read 'event' in the reducer.
| manipulateStartTime(); | ||
| manipulateEndTime(); | ||
| } | ||
| }, [eventData]); |
There was a problem hiding this comment.
React Hook useEffect has missing dependencies: 'manipulateEndTime' and 'manipulateStartTime'. Either include them or remove the dependency array.
…le input page to match design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors:
brelieu05, jessieh9
What does this PR contain?
Matched Hi-Fi Design and Implemented Edit Event Modal + Button
How did you test these changes?
Compared with Figma to see if implemented code closely matches the design (Button, Modal, etc.).
Closes #155