Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modal styling + optional email #171

Merged
merged 2 commits into from
Apr 19, 2024
Merged

fix: modal styling + optional email #171

merged 2 commits into from
Apr 19, 2024

Conversation

KatyH820
Copy link
Contributor

@KatyH820 KatyH820 commented Apr 18, 2024 •
edited
Loading

  • Change the modal to be submittable even if the email field is blank
  • Remove the terms and conditions hyperlink
  • When a guest registers, their status of is_checked_in should default to true instead of false
  • Add the missing person icon under the "Party size" input field

close #166

@KatyH820 KatyH820 linked an issue Apr 18, 2024 that may be closed by this pull request
RegisterGuestModal Bug Fixes #166
Closed
@KatyH820 KatyH820 marked this pull request as draft April 18, 2024 07:31
@KatyH820 KatyH820 requested review from NwinNwin and Aokijiop April 18, 2024 08:44
@KatyH820 KatyH820 marked this pull request as ready for review April 18, 2024 08:45
Aokijiop
Aokijiop approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@Aokijiop Aokijiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@Aokijiop Aokijiop merged commit d87cc1a into main Apr 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aokijiop Aokijiop Aokijiop approved these changes

@NwinNwin NwinNwin Awaiting requested review from NwinNwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RegisterGuestModal Bug Fixes
2 participants
@KatyH820 @Aokijiop