fix: Datetimepicker typecheck (#244)

ctrlplanedev · Dec 2, 2024 · d9d948e · d9d948e
1 parent 8c72cc0
commit d9d948e
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 12 deletions.
diff --git a/.../src/app/[workspaceSlug]/(app)/_components/environment-policy-drawer/RolloutAndTiming.tsx b/.../src/app/[workspaceSlug]/(app)/_components/environment-policy-drawer/RolloutAndTiming.tsx
@@ -148,10 +148,13 @@ export const RolloutAndTiming: React.FC<{
                             onChange={(t) => {
                               onChange({
                                 ...value,
-                                startTime: t.toDate(
-                                  Intl.DateTimeFormat().resolvedOptions()
-                                    .timeZone,
-                                ),
+                                startTime:
+                                  t != null
+                                    ? t.toDate(
+                                        Intl.DateTimeFormat().resolvedOptions()
+                                          .timeZone,
+                                      )
+                                    : new Date(),
                               });
                             }}
                           />{" "}
@@ -161,10 +164,13 @@ export const RolloutAndTiming: React.FC<{
                             onChange={(t) => {
                               onChange({
                                 ...value,
-                                endTime: t.toDate(
-                                  Intl.DateTimeFormat().resolvedOptions()
-                                    .timeZone,
-                                ),
+                                endTime:
+                                  t != null
+                                    ? t.toDate(
+                                        Intl.DateTimeFormat().resolvedOptions()
+                                          .timeZone,
+                                      )
+                                    : new Date(),
                               });
                             }}
                             aria-label="End Time"

diff --git a/apps/webservice/src/app/[workspaceSlug]/(app)/_components/filter/DateConditionRender.tsx b/apps/webservice/src/app/[workspaceSlug]/(app)/_components/filter/DateConditionRender.tsx
@@ -82,7 +82,7 @@ export const DateConditionRender: React.FC<DateConditionRenderProps> = ({
       <div className="col-span-7">
         <DateTimePicker
           value={toZonedDateTime(new Date(value))}
-          onChange={setDate}
+          onChange={(value) => value != null && setDate(value)}
           aria-label={type}
           variant="filter"
         />

diff --git a/apps/webservice/src/app/[workspaceSlug]/(app)/systems/JobHistoryChart.tsx b/apps/webservice/src/app/[workspaceSlug]/(app)/systems/JobHistoryChart.tsx
@@ -272,7 +272,7 @@ export const JobHistoryChart: React.FC<{
                 animationDuration={animationDuration}
                 fill={color}
                 onClick={(e) => {
-                  const start = new Date(e.date);
+                  const start = new Date((e as any).date);
                   const end = addDays(start, 1);
 
                   const afterStartCondition: JobCondition = {

diff --git a/packages/ui/src/date-time-picker/date-time-picker.tsx b/packages/ui/src/date-time-picker/date-time-picker.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable  @typescript-eslint/unbound-method */
 "use client";
 
 import type { DateValue } from "react-aria";
@@ -71,7 +70,7 @@ const DateTimePicker = React.forwardRef<
               <TimeField
                 aria-label="time-field"
                 value={state.timeValue}
-                onChange={state.setTimeValue}
+                onChange={(value) => value != null && state.setTimeValue(value)}
               />
             )}
           </div>