Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: e2e tests and context for event handling in cluster-scoped resources #2

Closed
wants to merge 1 commit into from
Closed

fix: e2e tests and context for event handling in cluster-scoped resources #2

wants to merge 1 commit into from

Conversation

eshaanm25
Copy link

What this PR does / why we need it:

  • Fixes e2e tests that were failing (1, 2, 3, 4, 5, 6) by correcting the namespace that the test was looking for events in.
  • Add a note in the READMEs, flag descriptions, and docs indicating that cluster scoped resources would create events in the GK namespace (based on the following suggestion)

@ctrought @eshaanm25
Merge pull request #1 from eshaanm25/fix-emit-events-namespace
812381c 
fix: e2e tests and context for event handling in cluster-scoped resources
Signed-off-by: Eshaan Mathur <[email protected]>
@eshaanm25 eshaanm25 closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshaanm25 @ctrought