-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assignment 5 complete #3
base: Assignment-5-base
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing autotest at https://github.com/cu-ecen-aeld/assignment-5-sota6640/actions
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sota6640 ensure you don't have binaries checked into your repo, this will cause issues with assignment 6.
{ | ||
syslog(LOG_DEBUG, "Caught signal, exiting"); | ||
caught_sigalarm = true; | ||
closeAll(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sota6640 is this safe to do in a signal handler?
int err1 = errno; | ||
syslog(LOG_ERR, "Failed to write bytes: errno -> %d", err1); | ||
syslog(LOG_ERR, "error string is %s", strerror(errno)); | ||
exit(EXIT_FAILURE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens to the allocated memory in this case?
There are multiple places where you forgot to free the memory before you exit.
No description provided.