Assignment 6 complete #4
Conversation
There was a problem hiding this comment.
Passing autotest run at https://github.com/cu-ecen-aeld/assignment-6-sota6640/actions
Nice work!
| { | ||
| syslog(LOG_DEBUG, "Caught signal, exiting"); | ||
| caught_sigalarm = true; | ||
| closeAll(); | ||
| sig = 1; |
| } | ||
| total_size += strlen(timestamp); | ||
|
|
||
| rc = pthread_mutex_unlock(&writeSocket); |
There was a problem hiding this comment.
@sota6640 you could simplify the logic here and use a single unlock if you save the return value of write and act on it after unlocking, similar to what you do in threadfunc
|
|
||
| syslog(LOG_DEBUG, "Write completed to recvfile_fd"); | ||
| rc = pthread_mutex_lock(&ll_lock); |
There was a problem hiding this comment.
@sota6640 I don't know that the lock is serving any purpose here since you are only accessing the list in a single thread.
| ==7744== by 0x4866322: allocate_stack (allocatestack.c:622) | ||
| ==7744== by 0x4866322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660) | ||
| ==7744== by 0x10AA74: initTimer (aesdsocket.c:181) | ||
| ==7744== by 0x10B867: main (aesdsocket.c:569) |
There was a problem hiding this comment.
Is this the Valgrind error for the cleanup of timer thread create?
| { | ||
| int timer_rc; | ||
| pthread_t timertid; | ||
| if((timer_rc = pthread_create(&timertid, NULL, threadtimerfunc, NULL)) != 0) |
There was a problem hiding this comment.
Missing cleanup of this thread, this is what valgrind is warning you about.
| closelog(); | ||
| syslog(LOG_DEBUG, "PERFORMING CLEANUP1"); | ||
| //timer_delete(timerid); | ||
| pthread_mutex_destroy(&writeSocket); |
There was a problem hiding this comment.
@sota6640 you need to think about whether it's safe to do this cleanup action in each place where the cleanup function is called. writeSocket is one thing which probably isn't safe to destroy in every case you call this function, since your timerThread may still be running.
This is another reason why it's generally better/easier to do cleanup in one place and one code path, much easier to review sequencing.
No description provided.