-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assignment 4 complete #2
base: Assignment-3-complete
Are you sure you want to change the base?
Conversation
Full test for assignment 4 is completed through the buildroot repository, this repo is only used for unit testing in assignment 4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing autotest run at https://github.com/cu-ecen-aeld/assignment-4-traptibalgi/actions/runs/10984878833
Nice work!
{ | ||
ERROR_LOG("Sleep for wait_to_release_ms before locking mutex failed with error %s\n", strerror(errno)); | ||
thread_func_args->thread_complete_success = false; | ||
return thread_param; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@traptibalgi what happens to the mutex on this return path?
{ | ||
/* If ret non-zero, create failed*/ | ||
ERROR_LOG("pthread_create failed with error %s\n", strerror(errno)); | ||
return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@traptibalgi what happens to the memory in thread_data_s
in this code path?
No description provided.