Add v3 utils files in order to remove Route Summary #311
Conversation
alanna-zhou
requested review from
chalo2000,
aliciaxw,
yuna878,
connorreinhold,
raahimenon and
ckdesir
| */ | ||
| if (previousDirection.routeNumber === direction.routeNumber) { | ||
| route.directions.splice(index - 1, 2, mergeDirections(previousDirection, direction)); | ||
| index -= 1; // since we removed an element from the array |
There was a problem hiding this comment.
put this before route.directions.splice so you don't have to subtract twice (efficiency 🤩 transit will so much faster now)
There was a problem hiding this comment.
yikes im worried about making too many changes, so i'm going to hold off on this (since i didn't write any of this)
src/utils/RouteUtilsV3.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Returns whether [route] contains a bus trasnfer |
There was a problem hiding this comment.
hehe tyty for all these helpful comments lol i didnt even bother fixing the old stuff xD
|
transit should be good w/o routeSummary. i see that routeNumber was removed via #308 but that should be a simple fix! |
thanks chris!! i haven't removed routeNumber yet -- that's gonna be my next PR :) |
Overview
For a v3, iOS let me know that they don't need
Route Summaryanymore, and Android kindly is (in the process of?) pivoting to deprecatingRoute Summary! The point of this PR is to make v3 super clean and significantly less bulkier than v1 and v2. This may seem contradictory rn because I have to add extra files, but it's the only way I can make changes so that we can still offer backwards compat. Maybe a couple years down the line the next backend member can refactor these files into v1, but for now we're just going to have to deal with multiple versions of utils files :')Changes Made
Add
ParseRouteUtilsV3and aRouteUtilsV3so that we can removeRoute Summaryas a field for a route inv3/route.Test Coverage
Tested locally and it successfully removes route summary :)
I'll deploy this onto the devserver and see if it breaks integration before merging into master
Next Steps
Get rid of routeID and analytics
Related PRs or Issues
#307