Elvis/status button #270
Elvis/status button #270
Conversation
| @@ -62,7 +62,8 @@ class HomeViewController: UIViewController { | |||
|
|
|||
| override func viewWillAppear(_ animated: Bool) { | |||
| super.viewWillAppear(animated) | |||
| navigationController?.tabBarController?.tabBar.isHidden = false | |||
| // navigationController?.tabBarController?.tabBar.isHidden = true | |||
There was a problem hiding this comment.
Just double checking, this is a temporary change right?
| make.width.equalTo(60) | ||
| make.height.equalTo(40) | ||
| } | ||
| } |
There was a problem hiding this comment.
Insert line after this }
There was a problem hiding this comment.
Looks good! Just a few small changes here and there
Some notes:
- You should turn on the swiftlint
- I would appreciate a PR title of a oneline description instead of j the branch name
- You should change the 'to' branch to be dev/homescreencapacity or some intermediate like that just to keep main fully functional at all times :))
There was a problem hiding this comment.
Double-check to see if this is not already in the assets folder. There is an asset titled "down-arrow-solid." Is this different than that?
| @@ -9,17 +9,18 @@ import SnapKit | |||
| import UIKit | |||
|
|
|||
| class HomeScreenHeaderView: UIView { | |||
|
|
|||
There was a problem hiding this comment.
Whitespace; you should turn on the swiftlint and make sure there's no styling related warnings before PR.
| var didSetupShadow = false | ||
|
|
||
| override init(frame: CGRect) { | ||
| super.init(frame: frame) | ||
|
|
||
| // BACKGROUND COLOR | ||
| backgroundColor = .white | ||
|
|
||
| make.width.equalTo(24) | ||
| make.height.equalTo(24) | ||
| make.centerY.equalToSuperview() | ||
| make.leading.equalToSuperview().offset(10) | ||
| } | ||
|
|
||
| dropDownImageView.snp.makeConstraints { make in | ||
| make.width.equalTo(8) | ||
| make.height.equalTo(8) | ||
| make.centerY.equalTo(circularView) | ||
| make.trailing.equalToSuperview().inset(10) |
There was a problem hiding this comment.
I feel like it could be good to separate out all the constants in an enum LayoutConstants at the top of the class.
| private func createCircularPath() { | ||
| self.layer.cornerRadius = width!/2 | ||
| let circularPath = UIBezierPath(arcCenter: CGPoint(x: width/2, y: width/2) , radius: (width - 1.5)/2, startAngle: CGFloat(-0.5 * .pi), endAngle: CGFloat(2.0 * .pi), clockwise: true) | ||
|
|
There was a problem hiding this comment.
Is this going to be used for the capacities? If so, I think it would be cool to make this more generic maybe with a percent, start angle, andlinewidth (and maybe animated??). Ofc that's something that could be done later as well.
|
|
||
| class StatusButton: UIButton { | ||
|
|
||
| var circularView: UIView! |
There was a problem hiding this comment.
of type CircleProgressView instead of UIView
|
|
||
| @objc func showCapacityView() { | ||
| if (statusButton.tag == 0) { | ||
| statusButton.backgroundColor = .gray00 |
There was a problem hiding this comment.
I think the design has it as white? imo based on the video having that extra contrast of white feels like it would make it more noticeable.
|
|
||
|
|
||
| @objc func showCapacityView() { | ||
| if (statusButton.tag == 0) { |
There was a problem hiding this comment.
I feel like it would enhance readability to use a boolean variable instead of the tag property. Maybe as a property of statusButton like statusButton.isDisclosed.
There was a problem hiding this comment.
To add on, you could also do this in a way which moves a lot of functionality into the status button. This function could literally have two lines:
statusButton.toggleDisclosure()
delegate.didToggleDisclosure() // For communicating with the homeviewcontroller
and then everything else such as background color could stay in the status button
Overview
Added the status button + cute animations to the home screen.
Next Steps (delete if not applicable)
Implementing button action.
Screen Recording
Button
button.mp4