-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(schema-compiler): Fix pre-agg matching for 'rollupJoin' / 'rollupLambda' pre-aggregations #10017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
8e58477
to
094dd8b
Compare
094dd8b
to
76fe519
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10017 +/- ##
===========================================
- Coverage 77.13% 48.82% -28.32%
===========================================
Files 440 196 -244
Lines 89307 15847 -73460
Branches 3101 3103 +2
===========================================
- Hits 68889 7737 -61152
+ Misses 20029 7720 -12309
- Partials 389 390 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…Lambda' pre-aggregations
76fe519
to
b14bf54
Compare
42cda6b
to
48b1d14
Compare
This PR fixes incorrect pre-agg matching in case of 'rollupJoin' / 'rollupLambda' pre-aggs
Check List