Skip to content

fix(schema-compiler): Fix incorrect truncated time dimensions over time series queries for BigQuery #9615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 25, 2025
Merged

fix(schema-compiler): Fix incorrect truncated time dimensions over time series queries for BigQuery #9615

merged 12 commits into from
Jun 25, 2025
+36,858 −789

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented May 23, 2025 •
edited
Loading

This depends on #9630 and #9640 for test correctness (because of result rows ordering and transformation).

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon marked this pull request as ready for review May 23, 2025 16:13
@KSDaemon KSDaemon requested review from a team as code owners May 23, 2025 16:13
@KSDaemon KSDaemon force-pushed the fix/incorrect-gran-4-rw-bq branch 3 times, most recently from 272275e to 5e14c3f Compare May 30, 2025 17:21
@KSDaemon KSDaemon force-pushed the fix/incorrect-gran-4-rw-bq branch from 5e14c3f to 7266182 Compare June 11, 2025 08:20
@KSDaemon KSDaemon force-pushed the fix/incorrect-gran-4-rw-bq branch 5 times, most recently from ee873bd to 0c1c3f1 Compare June 23, 2025 19:30
@KSDaemon KSDaemon force-pushed the fix/incorrect-gran-4-rw-bq branch from 0c1c3f1 to fd13815 Compare June 24, 2025 11:47
@KSDaemon KSDaemon force-pushed the fix/incorrect-gran-4-rw-bq branch from 2bcb287 to b43701e Compare June 24, 2025 20:47
@KSDaemon KSDaemon merged commit b075966 into master Jun 25, 2025
86 checks passed
@KSDaemon KSDaemon deleted the fix/incorrect-gran-4-rw-bq branch June 25, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waralexrom waralexrom waralexrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KSDaemon @waralexrom