Make the new multiple-inputs optimization function the default. #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
…d `split_every` to reduction functions in array API
tomwhite
force-pushed
the
enable-new-optimizer-by-default
branch
from
247d52e
to
31e7eb7
Compare
Fixed in #416 |
|
This also enables the new reduction implementation by default. It's possible to disable on a per-function basis if needed by calling e.g. |
This was referenced Mar 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been testing this a bit at scale, and I think it's ready to enable the new optimization function (
multiple_inputs_optimize_dag) as the default. (#397 explains how it works in more detail.)