This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
Get specific available machines by label, tag and platform. #3186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! But first: did you read our community guidelines?
https://cuckoo.sh/docs/introduction/community.html
What I have added/changed is:
I submit multiple files with a specific machine names, platforms or tags. I submit more files with these parameters than there are machines that match these characteristics in my Cuckoo system. I want these files that cannot be assigned to a machine right away to wait in the queue. They currently do not in v2.0.7 implementation of
scheduler
, and instead sit in a weird limbo state where they get picked off the queue and then waits for a machine to become available that matches these parameters.This fix applies to the KVM machinery and label, platform and tags at the moment, by overriding the
availables
method and provides the option to get the count of specific available machines.I feel like this should be implemented in the
scheduler
, but I can see the argument to have this implemented inself.db.fetch()
as well. Let me know what you think!The goal of my change is:
Fix the weird limbo state.
What I have tested about my change is:
Manual testing for correct functionality.