Skip to content
This repository has been archived by the owner on Apr 26, 2021. It is now read-only.

Get specific available machines by label, tag and platform. #3186

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cccs-kevin
Copy link

@cccs-kevin cccs-kevin commented Mar 18, 2021

Thanks for contributing! But first: did you read our community guidelines?
https://cuckoo.sh/docs/introduction/community.html

What I have added/changed is:

I submit multiple files with a specific machine names, platforms or tags. I submit more files with these parameters than there are machines that match these characteristics in my Cuckoo system. I want these files that cannot be assigned to a machine right away to wait in the queue. They currently do not in v2.0.7 implementation of scheduler, and instead sit in a weird limbo state where they get picked off the queue and then waits for a machine to become available that matches these parameters.

This fix applies to the KVM machinery and label, platform and tags at the moment, by overriding the availables method and provides the option to get the count of specific available machines.

I feel like this should be implemented in the scheduler, but I can see the argument to have this implemented in self.db.fetch() as well. Let me know what you think!

The goal of my change is:

Fix the weird limbo state.

What I have tested about my change is:

Manual testing for correct functionality.

@cccs-kevin cccs-kevin changed the title Get specific available machines by tag, platform, and label. Get specific available machines by tag and platform. Mar 18, 2021
@cccs-kevin cccs-kevin changed the title Get specific available machines by tag and platform. Get specific available machines by label, tag and platform. Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant