Skip to content

internal/encoding/gotypes: support go import aliasing #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

internal/encoding/gotypes: support go import aliasing #4028

wants to merge 12 commits into from

Conversation

phoban01
Copy link
Contributor

@phoban01 phoban01 commented Aug 14, 2025 •
edited
Loading

This change enables support for exporting aliased package names from source cue to go code.

Fixes #3974

@phoban01 phoban01 requested a review from cueckoo as a code owner August 14, 2025 10:58
mvdan
mvdan requested changes Aug 29, 2025
View reviewed changes
Copy link
Member

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch! This is roughly in line with what I was thinking, and thank you for writing tests. I think a couple of edge cases still need to be ironed out, though.

@mvdan mvdan self-assigned this Aug 29, 2025
@phoban01
Copy link
Contributor Author

Thank you for the patch! This is roughly in line with what I was thinking, and thank you for writing tests. I think a couple of edge cases still need to be ironed out, though.

Thank you for the detailed review @mvdan. I've addressed all the comments, with just the one clarification needed.

@phoban01
internal/encoding/gotypes: support go import aliasing
99e3745 
This change enables support for exporting aliased package names from
source cue to go code.

The special case of the "_" import alias is explicitly ignored.

Fixes cue-lang#3974

Signed-off-by: Piaras Hoban <[email protected]>
@phoban01
fix: rewrite test to avoid cue.mod/gen
d712913 
Signed-off-by: Piaras Hoban <[email protected]>
@phoban01
fix: avoid two-layer format
1d08d49 
Signed-off-by: Piaras Hoban <[email protected]>
@phoban01
fix: undo whitespace addition
5e57442 
Signed-off-by: Piaras Hoban <[email protected]>
@phoban01
fix: reword doc string
6132cd4 
Signed-off-by: Piaras Hoban <[email protected]>
@phoban01
fix: rename aliasLookup -> importAliases
9b70324 
Signed-off-by: Piaras Hoban <[email protected]>
@phoban01
fix: simplify gatherImportAliases; removing _ alias check
b887614 
Signed-off-by: Piaras Hoban <[email protected]>
@phoban01
fix: do not pass importAliases when generating goPkgName
d5bae8b 
Signed-off-by: Piaras Hoban <[email protected]>
@phoban01
fix: ensure conflicting aliases are handled
a50de83 
Signed-off-by: Piaras Hoban <[email protected]>
@phoban01
fix: handle duplicate alias/package names
9ac432f 
Signed-off-by: Piaras Hoban <[email protected]>
@phoban01 phoban01 force-pushed the support-generating-go-import-alias branch from 80ef0f1 to 9ac432f Compare September 19, 2025 12:03
mvdan
mvdan approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one last nit.

@phoban01
Copy link
Contributor Author

phoban01 commented Oct 7, 2025

Thanks @mvdan.

mvdan
mvdan approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cueckoo cueckoo closed this in ba534b5 Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mvdan mvdan mvdan approved these changes

@cueckoo cueckoo Awaiting requested review from cueckoo cueckoo is a code owner

Assignees

@mvdan mvdan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cmd/cue: exp gengotypes fails to handle conflicting imports

2 participants

@phoban01 @mvdan