cmd/cue: add --outfile flag to get go
#4118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fionera
force-pushed
the
feature/get-go-one-shot
branch
from
56697cf to
3a72ca5
Compare
mvdan
reviewed
Oct 6, 2025
|
|
||
| pkg := &cueast.Package{Name: e.ident(pName, false)} | ||
| addDoc(f.Doc, pkg) | ||
| if flagOutFile.IsSet(e.cmd) && i != len(p.Syntax)-1 { |
There was a problem hiding this comment.
pretty funky. the logic is not particularly easy to follow. can we add more comments? perhaps one jsut above the main for loop, explaining how the regular and "outfile" modes differ.
There was a problem hiding this comment.
Yeah. The logic is kinda ugly but I stared the last two hours on this and didn't found a nice way to structure this that wouldn't copy all the logic
There was a problem hiding this comment.
Nothing obvious comes to mind, the code as is is fine - it just needs a bit of a summary, like "in outfile mode, we accumulate into a single cue file and we write when we're done with the last go file".
fionera
force-pushed
the
feature/get-go-one-shot
branch
from
3a72ca5 to
2ffd695
Compare
|
Ah forgot the test, ignore the request for review. Sorry ^^' |
This introduces a way to write generated cue schemas to a given file or stdout. It joins all declarations into one giant file and preserves all package comments. Signed-off-by: Tim Windelschmidt <[email protected]>
fionera
force-pushed
the
feature/get-go-one-shot
branch
from
2ffd695 to
a7ac603
Compare
|
Now with added test 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a way to write generated cue schemas to a given file or stdout. It joins all declarations into one giant file and preserves all package comments.
Closes #4108