preprocessor: do not honour CUE_UNSAFE_NETWORK_HOST in multi-step

WIP Preprocessor-No-Write-Cache: true Signed-off-by: Paul Jolly <[email protected]> Change-Id: I64664fb836cbfe1f7f0e1e94e417595d102e84ed Dispatch-Trailer: {"type":"trybot","CL":1176742,"patchset":2,"ref":"refs/changes/42/1176742/2","targetBranch":"alpha"}
cue-lang · Feb 12, 2024 · 0258bd6 · 0258bd6
1 parent fc293a8
commit 0258bd6
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/internal/cmd/preprocessor/cmd/rootfile.go b/internal/cmd/preprocessor/cmd/rootfile.go
@@ -579,12 +579,9 @@ func (m *multiStepScript) run() (runerr error) {
 		"-v", fmt.Sprintf("%s:/scripts", scriptsDir),
 	)
 
-	// If the user wants to be unsafe and _not_ isolate the network let them
-	// It results in much faster running times when working on changes in the
-	// preprocessor.
-	if os.Getenv("CUE_UNSAFE_NETWORK_HOST") != "" {
-		args = append(args, "--network=host")
-	}
+	// We cannot perform the --network=host trick here, even if the user wants
+	// to be unsafe. Because we run cue mod registry which requires its own
+	// networking isolation (for binding to the port it will use etc).
 
 	args = append(args,
 		// TODO: support per-guide docker images