Skip to content

Commit

Permalink
_scripts: remove docker build -v flag
Browse files Browse the repository at this point in the history
A -v flag was incorrectly added to a docker-build command in
https://cuelang.org/cl/1203098. This wasn't caught in CI as the
conditional branch containing it is not exercised in CI, and is only
used in local workflows when podman is installed instead of docker.

Signed-off-by: Jonathan Matthews <[email protected]>
Change-Id: I95e20d5bc6c0c4d58d4e81c08a2efa1fa414af62
Dispatch-Trailer: {"type":"trybot","CL":1203200,"patchset":1,"ref":"refs/changes/00/1203200/1","targetBranch":"master"}
  • Loading branch information
jpluscplusm authored and cueckoo committed Oct 28, 2024
1 parent 6b29f8a commit 1951707
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion _scripts/buildDockerImage.bash
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ commonBuildArgs="-t $tag --build-arg GOPRIVATE=\"$(go env GOPRIVATE)\" -f ./_doc
# caching layer. This is particularly important in CI.
if docker help | grep -q podman
then
docker build -v $commonBuildArgs
docker build $commonBuildArgs
else
docker buildx build $caching --load $commonBuildArgs
fi

0 comments on commit 1951707

Please sign in to comment.