Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugo: Modified blue tint for base styling #474

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Wies-UsMedia
Copy link
Collaborator

@Wies-UsMedia Wies-UsMedia commented Oct 25, 2024

@Wies-UsMedia Wies-UsMedia self-assigned this Oct 25, 2024
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for cue ready!

Name Link
🔨 Latest commit 2f34701
🔍 Latest deploy log https://app.netlify.com/sites/cue/deploys/673456f22cc897000826b0c4
😎 Deploy Preview https://deploy-preview-474--cue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@JorindeUsMedia JorindeUsMedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is $c-blue still used anywhere after this change?
If not I would suggest assigning the value that is now assigned to $c-blue--light to $c-blue and getting rid of --light

@Wies-UsMedia
Copy link
Collaborator Author

Question: is $c-blue still used anywhere after this change? If not I would suggest assigning the value that is now assigned to $c-blue--light to $c-blue and getting rid of --light

Updated accordingly.

@Wies-UsMedia Wies-UsMedia marked this pull request as ready for review October 31, 2024 10:18
Copy link
Collaborator

@JorindeUsMedia JorindeUsMedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The $c-blue--light from before which is been replaced by $c-blue is not changed in all scss files yet. I now get the very light blue as nav text for instance. Please check all usage of $c-blue--light and check if it needs to be replaced with $c-blue now.

image

image

@Wies-UsMedia
Copy link
Collaborator Author

The $c-blue--light from before which is been replaced by $c-blue is not changed in all scss files yet. I now get the very light blue as nav text for instance. Please check all usage of $c-blue--light and check if it needs to be replaced with $c-blue now.

image

image

I believe I caught all of them now, but let me know if you still find a few out of place.

@Wies-UsMedia Wies-UsMedia marked this pull request as ready for review November 1, 2024 15:40
@jpluscplusm jpluscplusm self-assigned this Nov 7, 2024
The darker blue tint used across the site has been replaced by the
brighter blue version.

To compare, see:
https://cuelang.org/examples/shortcodes/info/
https://cuelang.org/examples/shortcodes/buttons/

Fixes cue-lang/cue#3503

Signed-off-by: Wies de Graaf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants