hugo: show background color on all inline code blocks #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* Removed the code that only adds a background
to inline code when inside p or list
* Give code element a transparent background
when inside of pre element.
Test:
* Add inline code to some steps and see if they
have a background color:
/examples/shortcodes/step/
* Check all other uses for code,
not only inline, e.g.:
* /examples/basic/code-block/
* /examples/shortcodes/code-tabs/
Fixes
cue-lang/cue#3003
and
cue-lang/cue#3498
Signed-off-by: Anne van Gorkom <[email protected]>
anne-usmedia
force-pushed
the
usmedia/3003
branch
from
faae784 to
79abee8
Compare
JorindeUsMedia
approved these changes
Jan 3, 2025
jpluscplusm
approved these changes
Jan 6, 2025
|
After merging, I noticed a regression caused by this change. This is tracked as cue-lang/cue#3656. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test:
/examples/shortcodes/step/
Fixes
cue-lang/cue#3003
and
cue-lang/cue#3498