Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contribution-guidelines): update installation steps #169

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

JowiAoun
Copy link
Collaborator

@JowiAoun JowiAoun commented Nov 1, 2024

  • Modified .env variables setup steps for authentication
  • Add docker daemon note
  • Change db:migrate step to db:push
  • Remove legacy steps
  • Fixed typo in app name web as opposed to website

Summary by CodeRabbit

  • Documentation
    • Updated contribution guidelines for project setup.
    • Added a warning about the Docker daemon requirement.
    • Clarified Google OAuth authentication steps and file configurations.
    • Changed database migration command to reflect new strategy.
    • Updated project commands to use "website" instead of "web."
    • Introduced an accordion section for better organization of Google OAuth steps.

Copy link

coderabbitai bot commented Nov 1, 2024

Warning

Rate limit exceeded

@MFarabi619 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 5 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 86c02a6 and 15ebd06.

📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request modifies the documentation for contribution guidelines, specifically enhancing the setup process for the project. Key changes include the addition of a warning about the Docker daemon, removal of legacy steps, and updates to the Google OAuth authentication instructions. The command for database migrations has been changed, and project commands have been updated to reflect a naming change from web to website. A new accordion section for Google OAuth has been added for better organization, while the overall structure remains intact.

Changes

File Path Change Summary
apps/docs/src/content/docs/contribution-guidelines/index.mdx - Added a warning about the Docker daemon requirement.
- Removed legacy steps related to monorepo migration.
- Updated Google OAuth setup instructions, including .env file handling.
- Changed migration command from pnpm nx run db:migrate to pnpm nx run db:push.
- Updated project commands from web to website.
- Added an accordion section for Google OAuth setup.

Possibly related PRs

  • KHasith/docs/overhaul outdated content #167: The changes in this PR also focus on updating the contribution guidelines documentation, specifically enhancing clarity and usability for contributors, which aligns with the main PR's goal of improving the contribution guidelines.

Suggested labels

bug, frontend

Suggested reviewers

  • HasithDeAlwis
  • MFarabi619

Poem

In the garden where we play,
Contribution guides light the way.
With Docker running, set the scene,
OAuth steps, clear and keen.
From web to website, we now glide,
In harmony, we take great pride! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for docs-cuhacking ready!

Name Link
🔨 Latest commit 15ebd06
🔍 Latest deploy log https://app.netlify.com/sites/docs-cuhacking/deploys/67245851acdf010008069392
😎 Deploy Preview https://deploy-preview-169--docs-cuhacking.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
apps/docs/src/content/docs/contribution-guidelines/index.mdx (3)

180-182: Enhance the Docker daemon warning message.

While the warning is well-placed, consider making it more specific for new users.

- Docker daemon (i.e. Docker Desktop) should be running before proceeding!
+ Docker daemon must be running (you should see the Docker Desktop icon in your system tray/menu bar) before proceeding!

211-213: Add environment variables format example.

Consider adding an example format for the environment variables to prevent confusion.

  Make a copy of the `.env.example` file in the `apps/portal` directory, and rename it to `.env.local`.
  Then, copy & paste the google client ID and secret into your the `.env.local` file as
  `GOOGLE_CLIENT_ID` and `GOOGLE_CLIENT_SECRET` respectively.
+ For example:
+ ```env
+ GOOGLE_CLIENT_ID=your-client-id-here.apps.googleusercontent.com
+ GOOGLE_CLIENT_SECRET=your-secret-here
+ ```

225-228: Add context for the database command change.

Consider explaining the difference between db:migrate and db:push to help users understand the change.

  Run Drizzle Push, to push the latest migration to your development database.
+ 
+ > Note: We now use `db:push` instead of `db:migrate` as it automatically synchronizes your database schema with your Drizzle schema without requiring explicit migration files.

  ```sh title="Terminal"
  pnpm nx run db:push

</blockquote></details>

</blockquote></details>

<details>
<summary>📜 Review details</summary>

**Configuration used: CodeRabbit UI**
**Review profile: CHILL**

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 2c5c18d9c42db8245b9d1750125fc09fecfb4655 and 86c02a6ff27febdf533bbd1e1c0d433389fc840d.

</details>

<details>
<summary>📒 Files selected for processing (1)</summary>

* `apps/docs/src/content/docs/contribution-guidelines/index.mdx` (3 hunks)

</details>

<details>
<summary>🔇 Additional comments (2)</summary>

<details>
<summary>apps/docs/src/content/docs/contribution-guidelines/index.mdx (2)</summary>

`241-241`: **LGTM! Command updates are consistent.**

The website command updates from `web` to `website` are correctly implemented across all usage scenarios.



Also applies to: 246-246, 251-251

---

Line range hint `1-400`: **LGTM! Documentation structure is well-maintained.**

The changes have been integrated seamlessly while maintaining the document's clear, step-by-step structure. The updates improve clarity and accuracy of the setup process.

</details>

</details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for website-cuhacking ready!

Name Link
🔨 Latest commit 15ebd06
🔍 Latest deploy log https://app.netlify.com/sites/website-cuhacking/deploys/67245851016a65000834024f
😎 Deploy Preview https://deploy-preview-169--website-cuhacking.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JowiAoun JowiAoun force-pushed the jowi/fix/project-setup branch 2 times, most recently from b1cd63d to 86c02a6 Compare November 1, 2024 04:23
@MFarabi619 MFarabi619 merged commit 9c8a0f2 into cuhacking:main Nov 1, 2024
11 of 13 checks passed
@MFarabi619
Copy link
Member

🎉 This issue has been resolved in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants