Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Introduce Common Open Source Tooling into Codebase to Increase Productivity and Developer Experience #43

Conversation

MFarabi619
Copy link
Member

@MFarabi619 MFarabi619 commented Aug 6, 2024

  • Set up Commitlint to enforce Conventional Commits along with Commitizen CLI to lower the learning curve for the future FAANG 10x devs
  • Set up Git hooks with Husky
    • Has nothing to do with dogs
    • Pre-commit hook runs ESLint on staged files, no more nitpicky PR reviews
    • Commit Message hook runs Commitlint to stop commit messages like this: fixplsworkplsworkabcd 🤣
lazygit-hunks-and-commitizen-demo.mp4
  • Our platform is now versioned according to the SemVer specification with Semantic Release

    • It parses the conventional commit types and scope in the git commit history to auto-trigger version bumps and releases
  • What's better than one pipeline using pnpm you ask? Well of course it's three pipelines using bun 🤯

Triple the vroom vroom 🤖

image

TODO: Set up caching and run pipelines in aforementioned order rather than in parallel, but keep them on separate files. We can then say it failed the build/test/release pipeline. Makes communication and debugging a bit easier.

@MFarabi619 MFarabi619 added enhancement New feature or request infra Infrastructure modification labels Aug 6, 2024
@MFarabi619 MFarabi619 self-assigned this Aug 6, 2024
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for cuhacking-portal-test-deployment failed. Why did it fail? →

Name Link
🔨 Latest commit f7a4330
🔍 Latest deploy log https://app.netlify.com/sites/cuhacking-portal-test-deployment/deploys/66b1df542ffd1a0008071b22

@MFarabi619 MFarabi619 force-pushed the mfarabi/chore/35-introduce-common-open-source-tooling-into-codebase-to-increase-productivity-and-developer-experience branch 4 times, most recently from 04c5cf7 to 046bc71 Compare August 6, 2024 08:15
@MFarabi619 MFarabi619 changed the title chore: Introduce Common Oopen Source Tooling into Codebase to Increase Productivity and Developer Experience chore: Introduce Common Open Source Tooling into Codebase to Increase Productivity and Developer Experience Aug 6, 2024
@MFarabi619 MFarabi619 force-pushed the mfarabi/chore/35-introduce-common-open-source-tooling-into-codebase-to-increase-productivity-and-developer-experience branch 2 times, most recently from 7cfa809 to 354039e Compare August 6, 2024 08:29
@MFarabi619 MFarabi619 force-pushed the mfarabi/chore/35-introduce-common-open-source-tooling-into-codebase-to-increase-productivity-and-developer-experience branch from 354039e to f7a4330 Compare August 6, 2024 08:31
@MFarabi619
Copy link
Member Author

Looks like bun isn't as compatible with node as I thought. I've been bunned.

Will investigate more.

@MFarabi619 MFarabi619 merged commit 7668310 into main Aug 8, 2024
0 of 7 checks passed
@JowiAoun
Copy link
Collaborator

JowiAoun commented Aug 10, 2024

Looks like bun isn't as compatible with node as I thought. I've been bunned.

Will investigate more.

Since it is relevant, bun was problematic in the build but has been fixed in PR #53

@MFarabi619
Copy link
Member Author

MFarabi619 commented Aug 10, 2024

Looks like bun isn't as compatible with node as I thought. I've been bunned.
Will investigate more.

Since it is relevant, bun was problematic in the build but has been fixed in PR #53

Nice, #53 links to an issue rather than a PR by the way

@JowiAoun
Copy link
Collaborator

After some more testing it looks like it was not fixed. ☹️
I will keep the PR to push the hotfix and get us working builds, then we can look into switching to bun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infra Infrastructure modification
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[ADR] Introduce Common Open-Source Tooling into Codebase to Increase Productivity and Developer Experience
3 participants