-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(contribution-guidelines): add github issue and pull request guidelines and templates #83
docs(contribution-guidelines): add github issue and pull request guidelines and templates #83
Conversation
❌ Deploy Preview for cuhacking-portal-dev failed. Why did it fail? →
|
i think for the most part (issues + prs + commits including), ppl don't know the correct type to use (difference between a fix vs a chore), so I think clearly explaining/defining them in a page would be very beneficial. A decision chart could also be helpful with this as well.. |
7b401a5
to
d32c254
Compare
I'm also wondering what is the convention when naming issues (perhaps even prs as well), the templates currently setup |
this would also help with maybe creating more issue templates as well |
084984e
to
508691b
Compare
a043771
to
515bbb1
Compare
What I was thinking is to keep it simple like: Issue:
PR:
Branch:
or
Let me know what you think |
Ok cool, it was just issues I was wondering about. Also, I didn't know that scopes could be included in branches. Would that be recommended, or is just listing name/type/issue-number-and-name ok? |
@sourcery-ai review |
Reviewer's Guide by SourceryThis pull request adds comprehensive guidelines for creating pull requests, issues, and templates to improve the contribution process. It includes changes to the documentation and introduces new PR templates. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JeremyFriesenGitHub - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider simplifying the PR templates slightly to focus on the most critical information. This could help prevent overwhelming new contributors.
- The GitHub issues guidelines section is incomplete. Please finish documenting the guidelines for issue titles and descriptions.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx
Outdated
Show resolved
Hide resolved
22097c6
to
515bbb1
Compare
WalkthroughWalkthroughThe changes involve the removal of the "index" page from the Changes
Possibly related PRs
Suggested labels
Poem
Tip OpenAI O1 model for chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 8
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .github/PULL_REQUEST_TEMPLATE/docs.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/feature.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/test.md (1 hunks)
- apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx (1 hunks)
- apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx (1 hunks)
Files skipped from review due to trivial changes (3)
- .github/PULL_REQUEST_TEMPLATE/docs.md
- .github/PULL_REQUEST_TEMPLATE/feature.md
- .github/PULL_REQUEST_TEMPLATE/test.md
Additional context used
LanguageTool
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx
[uncategorized] ~27-~27: Possible missing article found.
Context: ...t for making sure your contributions to project are in the right format! Finding the ...(AI_HYDRA_LEO_MISSING_THE)
[style] ~54-~54: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 1298 characters long)
Context: ... the correct type for your contributions! ## GitHub issues guidelines GitHub is...(EN_EXCESSIVE_EXCLAMATION)
apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx
[uncategorized] ~13-~13: It appears that hyphens are missing in the adjective “up-to-date”.
Context: ...quest. This ensures that your branch is up to date with the latest changes in the main bra...(UP_TO_DATE_HYPHEN)
[style] ~15-~15: ‘exact same’ might be wordy. Consider a shorter alternative.
Context: ...ue per pull request, and always use the exact same PR title as the issue name. This makes ...(EN_WORDINESS_PREMIUM_EXACT_SAME)
[style] ~15-~15: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...b.com/jesseduffield/lazygit) makes this very quick and easy to do cleanly. ## Pull Reques...(EN_WEAK_ADJECTIVE)
Additional comments not posted (2)
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx (1)
23-55
: Excellent addition for contribution clarity.The "Finding Your Type" section is a valuable addition, providing clear definitions and examples for different types of contributions. This will greatly assist contributors in categorizing their work correctly.
Tools
LanguageTool
[uncategorized] ~27-~27: Possible missing article found.
Context: ...t for making sure your contributions to project are in the right format! Finding the ...(AI_HYDRA_LEO_MISSING_THE)
[style] ~54-~54: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 1298 characters long)
Context: ... the correct type for your contributions! ## GitHub issues guidelines GitHub is...(EN_EXCESSIVE_EXCLAMATION)
apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx (1)
11-12
: Consider updating the phrasing for clarity.The phrase "Always simple rebase" might be confusing. Consider rephrasing to enhance clarity:
-Always simple rebase your branch onto main before creating a pull request. +Always perform a simple rebase of your branch onto main before creating a pull request.This change clarifies the action to be taken and aligns with common documentation standards.
Likely invalid or redundant comment.
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx
Show resolved
Hide resolved
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx
Outdated
Show resolved
Hide resolved
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx
Outdated
Show resolved
Hide resolved
apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx
Outdated
Show resolved
Hide resolved
apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx
Outdated
Show resolved
Hide resolved
apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx
Outdated
Show resolved
Hide resolved
apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx
Outdated
Show resolved
Hide resolved
9aad86e
to
bc29510
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Inline review comments failed to post
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .github/PULL_REQUEST_TEMPLATE/docs.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/feature.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/test.md (1 hunks)
- apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx (1 hunks)
- apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/PULL_REQUEST_TEMPLATE/feature.md
- .github/PULL_REQUEST_TEMPLATE/test.md
Files skipped from review as they are similar to previous changes (1)
- .github/PULL_REQUEST_TEMPLATE/docs.md
Additional context used
LanguageTool
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx
[uncategorized] ~30-~30: You might be missing the article “the” here.
Context: ...t for making sure your contributions to project are in the right format! Finding the ...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
Additional comments not posted (4)
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx (2)
26-49
: Well-structured contribution types section.The new section "Finding Your Type" is well-structured and provides clear definitions for various types of contributions, which will help contributors categorize their contributions accurately.
Tools
LanguageTool
[uncategorized] ~30-~30: You might be missing the article “the” here.
Context: ...t for making sure your contributions to project are in the right format! Finding the ...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
50-57
: Clear and actionable GitHub issues guidelines.The new section "GitHub issues guidelines" provides clear and actionable guidelines for writing GitHub issues, enhancing the usability of the documentation and aligning with the PR objectives.
apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx (2)
11-13
: Essential guidance on rebasing.The section "Always Simple Rebase" provides essential guidance on rebasing onto
main
before creating a PR, aligning with best practices for maintaining a clean and up-to-date branch history.
17-113
: Comprehensive PR guidelines and checklist.The sections "Pull Request Guidelines" and "Pull Request Checklist" provide comprehensive guidance and a structured checklist for creating PRs. These enhancements align with the PR objectives to streamline PR submissions and improve collaboration within the project.
Comments failed to post (1)
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx (1)
22-25: Reminder: Address or update the TODO comment.
The TODO comment lists important tasks related to project management setup. It's crucial to address these tasks to ensure proper project management and communication channels are established.
Would you like me to help update this section or track the completion of these tasks in a project management tool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .github/PULL_REQUEST_TEMPLATE/docs.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/feature.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/test.md (1 hunks)
- apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx (1 hunks)
- apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx (1 hunks)
Files skipped from review due to trivial changes (3)
- .github/PULL_REQUEST_TEMPLATE/docs.md
- .github/PULL_REQUEST_TEMPLATE/feature.md
- .github/PULL_REQUEST_TEMPLATE/test.md
Files skipped from review as they are similar to previous changes (1)
- apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx
Additional context used
LanguageTool
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx
[uncategorized] ~30-~30: Possible missing article found.
Context: ...t for making sure your contributions to project are in the right format! Finding the ...(AI_HYDRA_LEO_MISSING_THE)
Additional comments not posted (3)
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx (3)
22-25
: Address the TODO for project management setup.The TODO at lines 22-25 mentions important setup tasks that need to be completed. It's crucial to address these to ensure proper project management and communication channels are established. This aligns with the previous comment by coderabbitai[bot] and remains relevant.
26-49
: Review and approve the new section "Finding Your Type".This new section provides clear definitions and examples for various contribution types, which is a significant enhancement to the documentation. It aligns well with the PR objectives and addresses the concerns raised in the comments about clarifying the differences between types like "fix" and "chore". The structured format and examples will aid contributors in accurately categorizing their contributions.
Tools
LanguageTool
[uncategorized] ~30-~30: Possible missing article found.
Context: ...t for making sure your contributions to project are in the right format! Finding the ...(AI_HYDRA_LEO_MISSING_THE)
50-57
: Review and approve the "GitHub issues guidelines" section.The new section on GitHub issues guidelines at lines 50-57 offers detailed advice on crafting titles, descriptions, using labels, and assigning issues. This section enhances the usability of the documentation by providing clear, actionable guidelines for contributors, which can lead to more effective project management and communication. The inclusion of an example issue link at line 59 is a practical addition, providing a real-world application of these guidelines.
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx
Outdated
Show resolved
Hide resolved
d72cc31
to
01d204e
Compare
Yes scopes could be included in branches. I'm not sure how What do you think? |
07d32dd
to
b7bc781
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (19)
- .github/ISSUE_TEMPLATE/architectural-design-record--adr-.md (1 hunks)
- .github/ISSUE_TEMPLATE/bug_report.md (1 hunks)
- .github/ISSUE_TEMPLATE/build.md (1 hunks)
- .github/ISSUE_TEMPLATE/chore.md (2 hunks)
- .github/ISSUE_TEMPLATE/ci.md (1 hunks)
- .github/ISSUE_TEMPLATE/docs.md (1 hunks)
- .github/ISSUE_TEMPLATE/feature.md (2 hunks)
- .github/ISSUE_TEMPLATE/perf.md (1 hunks)
- .github/ISSUE_TEMPLATE/test.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/build.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/chore.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/ci.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/docs.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/feature.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/fix.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/perf.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE/test.md (1 hunks)
- apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx (1 hunks)
- apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx (1 hunks)
Files skipped from review due to trivial changes (16)
- .github/ISSUE_TEMPLATE/architectural-design-record--adr-.md
- .github/ISSUE_TEMPLATE/build.md
- .github/ISSUE_TEMPLATE/chore.md
- .github/ISSUE_TEMPLATE/ci.md
- .github/ISSUE_TEMPLATE/docs.md
- .github/ISSUE_TEMPLATE/feature.md
- .github/ISSUE_TEMPLATE/perf.md
- .github/ISSUE_TEMPLATE/test.md
- .github/PULL_REQUEST_TEMPLATE/build.md
- .github/PULL_REQUEST_TEMPLATE/chore.md
- .github/PULL_REQUEST_TEMPLATE/ci.md
- .github/PULL_REQUEST_TEMPLATE/docs.md
- .github/PULL_REQUEST_TEMPLATE/feature.md
- .github/PULL_REQUEST_TEMPLATE/fix.md
- .github/PULL_REQUEST_TEMPLATE/perf.md
- .github/PULL_REQUEST_TEMPLATE/test.md
Additional context used
LanguageTool
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx
[style] ~48-~48: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 2896 characters long)
Context: ... the correct type for your contributions! ## GitHub issues guidelines GitHub is...(EN_EXCESSIVE_EXCLAMATION)
apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx
[uncategorized] ~13-~13: A comma might be missing here.
Context: ...R rules are set up for the repo just in case as a guardrail. Do your best to close ...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Additional comments not posted (6)
.github/ISSUE_TEMPLATE/bug_report.md (2)
4-4
: Improved title format for bug reports.The change to the title format encourages more descriptive bug reports, which can help in quicker identification and resolution of issues.
5-5
: Automatic labeling for bug reports.Setting the label to 'bug' automatically categorizes bug reports appropriately, aiding in efficient issue tracking and management.
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx (2)
26-47
: Clear guidance on categorizing contributions.The new section "Finding Your Type" provides clear definitions and examples for various types of contributions, enhancing the clarity and usability of the documentation.
50-57
: Enhanced guidelines for GitHub issues.The new section on GitHub issues guidelines offers detailed and actionable advice for crafting effective issues, which can lead to better project management and communication.
apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx (2)
11-24
: Comprehensive Pull Request Guidelines.The new section on Pull Request Guidelines provides detailed and clear instructions for contributors, enhancing the clarity and consistency of PR submissions.
Tools
LanguageTool
[uncategorized] ~13-~13: A comma might be missing here.
Context: ...R rules are set up for the repo just in case as a guardrail. Do your best to close ...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
34-113
: Effective Pull Request Checklist.The Pull Request Checklist is well-structured and covers essential aspects of code quality and PR review readiness, aiding contributors in ensuring their submissions meet the project's standards.
apps/docs/src/content/docs/contribution-guidelines/writing-documentation.mdx
Show resolved
Hide resolved
bc55abd
to
5a31042
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, docs are very nicely written and formatted, and thanks for adding the templates too 🙏
…nitions and checklist in writing documentation and pull requests page
6c28e37
to
c18d41b
Compare
Pull request was converted to draft
b7a72e5
to
57ac3a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very, very nice work on this 👍
|
||
### **Code Quality** | ||
|
||
<table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small nitpick, I don't really mind, but would like your opinion on this as well. We can use MD to write these:
Example:
- checkbox
I did this with "- [ ] checkbox"
Lmk your thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not work in mdx...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or at least you won't be able to interact with the checkbox at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really, on my end I can interact with it? It also persists, so if I check it and leave the page for me, I can still see it as checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird, for me it was not working nicely at all...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work for you in this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but mdx is not rly md, i talked to farabi abt it and he said it was normal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, i'm aware, but from waht I know checkboxes work in MDX and MD.
Refer to the PR below and you can interact with the checkboxes:
PR #60 is a good example
|
||
# 🚩 Linked issue | ||
|
||
**Please remember to link the according issue here in this section with a [hyperlink](https://github.com/cuhacking/2025/issues).** This will give reviewers a chance to look to see what problem you are trying to solve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice touch 🔥
|
||
Ensure that the issue is linked to your PR, and is part of a milestone. However, do not add it to the project board, because it shows up as a card and causes visual pollution. We can easily just see your linked PR from the closed issue if we need to find it. | ||
Do your best to close a single issue per pull request, and always use the same PR title as the issue name. This makes debugging easier later. If the current issue is blocking the next, simply create a new branch off the branch for the pull request and continue working on the next issue on that branch. This technique is called [branch stacking](https://medium.com/@lneves12/git-how-to-stack-multiple-git-branches-and-rebase-them-like-a-pro-91c0cdf67ef). With the power of `git rebase`, you can continually apply PR feedback for the first branch while making progress for the next task on the second branch. Once again, [Lazygit](https://github.com/jesseduffield/lazygit) makes this quick and easy to do cleanly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice link to the medium article 👍
thx, still tons left actually on the docs, but we need to at least get this through right now for better issue + pr documentation |
a26f957
to
08212ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx (2)
13-13
: Correct the hyphenation in "up-to-date".According to standard English usage, the phrase "up to date" should be hyphenated when used as an adjective:
-This ensures that your branch is up to date with the latest changes in the main branch. +This ensures that your branch is up-to-date with the latest changes in the main branch.
37-116
: The Pull Request Checklist looks great!The checklist is comprehensive and covers important aspects of code quality and PR review readiness. It ensures that contributors self-assess their code before submitting a pull request.
The past review comment by coderabbitai[bot] suggesting the addition of a section on security best practices and a reminder for accessibility checks is still valid and can be considered for future enhancements to further improve the checklist.
Add a comma in line 25 as suggested by LanguageTool:
-PR is clear and comprehensible +PR is clear and comprehensible,
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- apps/docs/src/content/docs/contribution-guidelines/meta.json (0 hunks)
- apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx (1 hunks)
- apps/docs/src/content/docs/knowledge-base/meta.json (1 hunks)
- apps/docs/src/content/docs/tools-overview/meta.json (1 hunks)
Files not reviewed due to no reviewable changes (1)
- apps/docs/src/content/docs/contribution-guidelines/meta.json
Files skipped from review as they are similar to previous changes (2)
- apps/docs/src/content/docs/knowledge-base/meta.json
- apps/docs/src/content/docs/tools-overview/meta.json
Additional context used
LanguageTool
apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx
[uncategorized] ~25-~25: Possible missing comma found.
Context: ...s solution-specific (describes only the solution since the issue describes the problem a...(AI_HYDRA_LEO_MISSING_COMMA)
Additional comments not posted (8)
apps/docs/src/content/docs/contribution-guidelines/pull-requests.mdx (8)
11-11
: LGTM!The heading is clear and concise.
15-15
: The past review comment by HasithDeAlwis appreciating the link to the Medium article is still valid and applicable.
17-24
: The new Pull Request Guidelines section looks great!The section provides clear and comprehensive guidance on creating pull requests. It covers important aspects such as being mindful of the contribution type, using appropriate templates, aligning PR scope and subject with commits, creating draft PRs for unfinished work, linking PRs with issues, and making the PR description solution-specific.
The past review comment by coderabbitai[bot] suggesting the addition of examples or more detailed explanations is still valid and can be considered for future enhancements to further assist contributors.
28-28
: LGTM!The suggestion to use Git Worktrees is helpful for contributors who frequently switch branches and want to avoid stashing changes or amending commits.
29-30
: LGTM!The example of a well-documented pull request is helpful for contributors to understand what a good pull request looks like.
31-32
: LGTM!The link to GitHub PR templates is helpful for contributors to use as a starting point for creating pull requests.
33-34
: LGTM!The guidance on creating pull requests that address multiple issues is clear and helpful. Breaking them down into smaller, more focused PRs that tackle one issue at a time is a good approach to avoid overwhelming reviewers and to make the documentation process easier.
35-36
: LGTM!The guidance on handling issues that blow up and cannot be split into multiple issues is clear and helpful. Keeping the issue open and making multiple PRs that complete it in increments is a good approach. The example provided is a good reference for contributors to understand how to handle such situations.
Description
Describe the PR with the following guidelines
What changes does this PR add?
This PR adds PR guidelines and a PR checklist to the writing documentation page on the docs site. Additionally, PR templates have also been created as well (in the .github directory).
Why do we need to add to the docs? How does this PR address the issue(s)?
This tries to attempt to make decent writing guidelines and solve the todo's for that page specifically. Automated PR templates are also a must and can help create contribution consistency among developpers.
Dependency Changes (if applicable)
N/A
Before and After Screenshots (if applicable)
Here is a before and after for the writing documentation page:
Additional comments (if applicable)
I've put this in draft because I wanted input on this so far (in terms of frontend layout, resources that we can use, etc.) I know right now this is not very pretty (nor perhaps as informative as it should be). Its definitely an issue I think that takes a strong second opinion for review. This is linked to issue #77. Issue #78 is also very likely to be incorporated into this PR as well, since its similar and also a todo for the writing documentation.
Summary by Sourcery
Enhance the contribution guidelines by adding comprehensive pull request guidelines, issue guidelines, and templates for features, tests, and documentation. Update the documentation to include a checklist for code quality and PR review, and remove the outdated pull request template.
Documentation:
Chores:
Summary by CodeRabbit
New Features
Documentation