Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate data on server using schema #100

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Validate data on server using schema #100

merged 2 commits into from
Jul 5, 2021

Conversation

dellisd
Copy link
Member

@dellisd dellisd commented Jul 2, 2021

Closes #93

ryanlyrl
ryanlyrl approved these changes Jul 5, 2021
View reviewed changes
server/src/main/kotlin/com/cuhacking/atlas/server/Server.kt Outdated
println(e.message)
e.causingExceptions.map(ValidationException::message).forEach(::println)
} catch (e: Exception) {
println(e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other particular errors we're expecting this to throw? Will returning true in any of those cases cause issues?

@dellisd dellisd merged commit 7ca4840 into master Jul 5, 2021
@dellisd dellisd deleted the schema-validation branch July 5, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanlyrl ryanlyrl ryanlyrl approved these changes

@deenhaque deenhaque Awaiting requested review from deenhaque

@ghaskins99 ghaskins99 Awaiting requested review from ghaskins99

@safa-howaid safa-howaid Awaiting requested review from safa-howaid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate data against schema instead of by parsing
2 participants
@dellisd @ryanlyrl