runtime: pprof label need to escape double quote

golang#53703
cuiweixie · Jul 7, 2022 · 2cc08d5 · 2cc08d5
1 parent 351e0f4
commit 2cc08d5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/runtime/pprof/label.go b/src/runtime/pprof/label.go
@@ -83,7 +83,9 @@ func Labels(args ...string) LabelSet {
 	}
 	list := make([]label, 0, len(args)/2)
 	for i := 0; i+1 < len(args); i += 2 {
-		list = append(list, label{key: args[i], value: args[i+1]})
+		key := strings.ReplaceAll(args[i], `"`, `\"`)
+		value := strings.ReplaceAll(args[i+1], `"`, `\"`)
+		list = append(list, label{key: key, value: value})
 	}
 	return LabelSet{list: list}
 }

diff --git a/src/runtime/pprof/label_test.go b/src/runtime/pprof/label_test.go
@@ -4,6 +4,7 @@ import (
 	"context"
 	"reflect"
 	"sort"
+	"strings"
 	"testing"
 )
 
@@ -81,6 +82,20 @@ func TestContextLabels(t *testing.T) {
 	}
 }
 
+func TestQuoteLabels(t *testing.T) {
+	key := `a "quote" key`
+	value := `a "quote" value`
+	quoteKey := strings.ReplaceAll(key, `"`, `\"`)
+	quoteValue := strings.ReplaceAll(value, `"`, `\"`)
+	l := Labels(key, value)
+	if l.list[0].key != quoteKey {
+		t.Errorf("labels: got %s, want %s", l.list[0].key, quoteKey)
+	}
+	if l.list[0].value != quoteValue {
+		t.Errorf("labels: got %s, want %s", l.list[0].value, quoteValue)
+	}
+}
+
 func TestLabelMapStringer(t *testing.T) {
 	for _, tbl := range []struct {
 		m        labelMap