Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rails #442

Merged
merged 68 commits into from
Jan 3, 2024
Merged

Update rails #442

merged 68 commits into from
Jan 3, 2024

Conversation

barmintor
Copy link
Member

Rails 5 and Ruby 2.7

@barmintor
Rails 5.2 and compatible dependencies
9dda17f
@barmintor
introduce ApplicationRecord base model
f88c6f2
@barmintor
throw(:abort) in authz before_action
ada6c04
@barmintor
do not inherit directly from ActiveRecord::Migration, use version number
0e081f8
@barmintor
rails 5.2 binstubs
a37d825
@barmintor
strong params in DigitalObjectController search methods
21988f4
@barmintor
utf conversion errors may be raised via JSON::GeneratorError
91d995b
@barmintor
association semantics for Rails 5 in spec fixture set ups
a4b0130
@barmintor
Rails 5.2 requires an association to be defined before being used as …
bbf1967 
…through relation
@barmintor
Rails 5 makes belongs_to required by default, and optional when speci…
8df3f53 
…fied
@barmintor
noid no longer permits #seed with no params, but previous behavior an…
f96b176 
… be emulated
@barmintor
update initializers for Rails 5.2 and use Rails 5.2 defaults
d430367 
- replace Hyacinth::Application initializer calls with Rails.application
- routing spec updates to use Rails.application
@barmintor
cul_hydra no longer includes unused Resource or BagAggregator models
910b690
@barmintor
post_via_redirect was removed; call follow_redirect! after post
ac94dee
@barmintor
guard clause in case jQuery.active returns null
01c1760
@barmintor
controller test methods now use keyword params for params and session
722b442
@barmintor
run CI against ruby 2.7.6
fa1e0b2
@elohanlon elohanlon force-pushed the 2.x-derivative-updates branch 2 times, most recently from 6bf3092 to d18177d Compare December 19, 2023 18:07
@barmintor
Rails 6.0 dependencies
d62a151
@barmintor
use Rails 6 initializers
6673e64 
- use Rails 6 defaults where appropriate
- use Rails.application.config_for
- configs will have symbol top-level keys
- idiomatic guard clauses
- use dig rather than chained presence checks
@barmintor
use Rails.application in routes config
d4d2a38
@barmintor
update the standard app environments for Rails 6
c310c39
@barmintor
update binstubs for Rails 6
d5e4d4c
@barmintor
update puma config
186687b
@barmintor
update test cable adapter config from async to test per Rails 6 defaults
8b30e56
@barmintor
explicitly name a shorter db index field name on controlled vocabularies
9c0c10f
@barmintor
ensure custom_field_key is a string before concatenating
8f1e79f
@barmintor
rename Assignments enum value 'annotate' to 'annotate_object'
35b5eeb 
- avoids a  collision with Rails 6 ActiveRecord method name
@barmintor
update development ruby version to 2.7.6
cf06341
elohanlon and others added 15 commits December 21, 2023 00:47
@elohanlon
Rubocop fix
133fbe7
@elohanlon
Update GitHub ci.yml file to set up node
162764f
@elohanlon
Fix a couple of errors that appear when using the Rails console on re…
539ee40 
…mote server
@elohanlon
Gemfile cleanup; Rename constant Hyacinth::XMLGenerator to Hyacinth::…
0ced1d3 
…XmlGenerator
@barmintor @elohanlon
use a cul_hydra ref with no blacklight dependency and some zeitwerk-f…
b61629f 
…riendly module renames
@elohanlon
Remove XmlGenerator inflection override now that XMLGenerator class h…
c698d54 
…as been renamed to XmlGenerator
@elohanlon
Remove some deprecation warnings
ead8367
@elohanlon
Switch to :hybrid cookie serializer during this transitional period s…
9ae0367 
…o that old Rails 4 app login sessions are respected
@elohanlon
Rubocop fix and comment update
01dbb2a
@elohanlon
Fix some more deprecation warnings
d190a5e
@elohanlon
Merge pull request #444 from cul/update-rails_no-blacklight_zeitwerk
1c57afa 
use a cul_hydra ref with no blacklight dependency
@elohanlon
Update to Rails 6.1
76fdfff
@elohanlon
Update rspec-rails and fix broken fixture_file_upload reference
7d4deb1
@elohanlon
Fixes for login in development environment; Switch from secrets.yml t…
d488372 
…o Rails encrypted credentials; Remove outdated initializers
@elohanlon
Add master.key to deployment config file symlink list (and remove sec…
4d42835 
…rets.yml)
@elohanlon
Update to bundler 2
1b0725b
@elohanlon
Require net-http gem explicitly (and allow any version) to fix an iss…
0518b65 
…ue where the net-protocol dependency is loaded twice; Remove min version specification for net-ssh gem
@elohanlon
Pin uri gem to 0.10.0 to match the default/standard gem version that …
0760058 
…comes with Ruby 2.7.8
@elohanlon
Add updateHandler configs to various solr cores (to fix error message…
09cabe6 
… related to lack of <updateLog/> configuration)
@elohanlon
Update: Actually pin uri gem to 0.10.0.2, because that's the version …
ccd6f82 
…that matches the default/standard gem version that comes with Ruby 2.7.8
@elohanlon
Update CI ruby version to 2.7.8
0289cc7
@elohanlon elohanlon merged commit 368e02b into 2.x-derivative-updates Jan 3, 2024
1 check passed
@elohanlon elohanlon deleted the update-rails branch January 3, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barmintor @elohanlon