Skip to content

Commit

Permalink
Update locales for "Add Filters" -> "Add filters" (#5430)
Browse files Browse the repository at this point in the history
* F to f

* Fix tests

* Fix tests

* Add changeset

---------

Co-authored-by: Christian Moore <[email protected]>
  • Loading branch information
Zystix and Christian Moore authored Dec 24, 2024
1 parent c78aa39 commit fbedd22
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 6 deletions.
5 changes: 5 additions & 0 deletions .changeset/cold-gorillas-invite.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@kaizen/components': patch
---

FilterBar: Update localisation to follow guidelines
2 changes: 1 addition & 1 deletion packages/components/locales/en-GB.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
},
"filterBar.addFiltersMenu.buttonLabel" : {
"description" : "Menu button label to show additional available filter options",
"message" : "Add Filters"
"message" : "Add filters"
},
"filterBar.clearAllButton.ariaLabel" : {
"description" : "Button aria-label to clear all values within the filter bar",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
},
"filterBar.addFiltersMenu.buttonLabel": {
"description": "Menu button label to show additional available filter options",
"message": "Add Filters"
"message": "Add filters"
},
"filterBar.clearAllButton.ariaLabel": {
"description": "Button aria-label to clear all values within the filter bar",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export const ClearAllFromRemovable: Story = {

await step('removable filter is added with no value', async () => {
await waitFor(() => {
userEvent.click(canvas.getByRole('button', { name: 'Add Filters' }))
userEvent.click(canvas.getByRole('button', { name: 'Add filters' }))
})

await waitFor(() => {
Expand Down Expand Up @@ -205,7 +205,7 @@ export const ClearAllRemovesItself: Story = {
const canvas = within(canvasElement.parentElement!)

await step('removable filter is added with no value', async () => {
await waitFor(() => userEvent.click(canvas.getByRole('button', { name: 'Add Filters' })))
await waitFor(() => userEvent.click(canvas.getByRole('button', { name: 'Add filters' })))
await userEvent.click(canvas.getByRole('button', { name: 'Drank' }))
})

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -791,10 +791,10 @@ export const UpdatesLabels: Story = {
const canvas = within(canvasElement)

await step('Initial render complete', async () => {
await waitFor(() => canvas.getByRole('button', { name: 'Add Filters' }))
await waitFor(() => canvas.getByRole('button', { name: 'Add filters' }))
})

await userEvent.click(canvas.getByRole('button', { name: 'Add Filters' }))
await userEvent.click(canvas.getByRole('button', { name: 'Add filters' }))

expect(canvas.queryByText('Custom Range')).not.toBeInTheDocument()

Expand Down

0 comments on commit fbedd22

Please sign in to comment.